Re: [tpmdd-devel] [PATCH] fix suspend and resume for tpm_nsc driver

[Marcel S. <tp...@se...>]

Hi,

now I have to apologize for how long it has taken me to test it.
It worked smoothly and I will post it upstream now.

Thanks again!
Marcel

David Smith schrieb:
> Ping. Was this acted upon?
> 
> 2008/7/30 David Smith <dd...@go...>:
>> I'm sorry for how long it has taken me to respond to this. Attached is the
>> fixed patch.
>>
>>
>> 2008/6/25 Marcel Selhorst <tp...@se...>
>>> Hi David,
>>>
>>> when applying your patch to vanilla 2.6.25 and recompiling the NSC-driver
>>> I get:
>>>
>>> CC [M]  drivers/char/tpm/tpm_nsc.o
>>> drivers/char/tpm/tpm_nsc.c: In function 'init_nsc':
>>> drivers/char/tpm/tpm_nsc.c:329: warning: assignment from incompatible
>>> pointer type
>>>
>>> Upon inserting the module I get a complete system crash with a
>>> null-pointer exception. The call trace includes
>>> tpm_nsc_init -> tpm_nsc_remove -> kobject-something.
>>>
>>> I suspect that the compiler warning is related to this issue.
>>>
>>> Best regards,
>>> Marcel
>>>
>>> David Smith schrieb:
>>>> Hi,
>>>>
>>>> When I have the tpm_nsc driver loaded, I cannot suspend properly on my
>>>> T43p. The symptoms are 100% reproducable and exactly the same as
>>>> described in this LKML thread:
>>>>
>>>>  http://lkml.org/lkml/2008/2/20/658
>>>>
>>>> Upon debugging the driver, it seems that the platform_suspend command
>>>> sends a struct platform_device to the suspend function, but the tpm_nsc
>>>> driver registers the tpm_pm_suspend function which expects a struct
>>>> device which causes the NULL pointer dereference. Adding wrapper
>>>> functions like those found in the tpm_tis module fixes the issue. I've
>>>> attached a patch to do this and clean up the device allocation a small
>>>> bit.
>>>>
>>>> Thanks,
>>>> - dds
>>>>
>>>>
>>>> ------------------------------------------------------------------------
>>>>
>>>> -------------------------------------------------------------------------
>>>> Check out the new SourceForge.net Marketplace.
>>>> It's the best place to buy or sell services for
>>>> just about anything Open Source.
>>>> http://sourceforge.net/services/buy/index.php
>>>>
>>>>
>>>> ------------------------------------------------------------------------
>>>>
>>>> _______________________________________________
>>>> tpmdd-devel mailing list
>>>> tpm...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
>>
> 
> 
>