From: Alexey D. <al...@da...> - 2006-03-04 17:08:11
|
Cool - I agree with all points: Both "ext" and "util" (or "utils" - whichever is better) sounds fine to me. I also agree on the point that all external stuff especially with the different license should go to ext (except qscintilla which we don't host at all and the build scriptf for Windows part ofit will go to util(s)). Marvellous - how hard it would be to update the unix build scripts? For windows part - it's just a day of work. Alexey Thomas Porschberg wrote: > Am Fri, 3 Mar 2006 09:13:33 -0000 > schrieb "Alexey Danilchenko" <a.d...@se...>: > > >>> 4) a "vendor" directory which contains "otl" as subdir and otlv4.h >>> inside the otl dir. >>> >> Although I don't mind this but I personally don't like the "vendor" >> name - kind of suggests that we might be using non opensourced stuff. >> >> > Yes, the name vendor seems not convincing. How about "ext" (like > external) ? > > >> Also, the OTL is not a module or add-on but integral part of the >> TOra so I don't think it needs to be separated as such. It is also a >> single file. >> > > Yes, OTL is only one single file (really cool) but from a mere technical > point of view it is an external library (with a certain license [and it > is not TOra code]). > I admit one such file would not justify the creation of a "ext" or > "vendor" direcory. But first it is by no means an mistake to do such an > separation and second maybe some day we want integrate another external > library to TOra. The natural place is then under ext/<new-lib> next to > ext/otl. > > >> If we are to create a separate directory to hold the foreign code why >> don't we place directories like otl or qscintilla directly in TOra >> directory? >> > > I think the main argument is to group things together which have the > same character. (all core-src at one place, all external libs at one > place, all doc at one place, all tool stuff at one place) > > >>>> I'm not sure about qscintilla(resides still in project-root, maybe >>>> a candidate for util), debian (in project-root) and rpm(in >>>> project-root). >>>> >>>> >>> I think qscintilla should go under windows, since it's only useful >>> for people building tora on windows... Or maybe windows should be >>> splitted in 2: >>> >> Guys I think you mixing two different things here. TOra does not hold >> *any* qscintilla source code. The qscintilla directory only contains >> the Windows build script for qscintilla since the qscintilla itself >> does not have any build scripts for QT-Free for Windows. Once build >> it is going to reside in QT3 directory and not in TOra. >> > > Therefore the util dir could be a good place. A build script is no > src-code and no documentation. > > >> The windows directory contains windows specific source code of TOra >> that accesses registry and other such stuff. It should probably be >> moved as subdirectory to the src. >> >> > I agree, this was my suggestion: > 1) a "src" directory which contains icons,qtlegacy,templates,windows as > ^^^^^^^ > subdirs > > Thomas > > > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting language > that extends applications into web and mobile media. Attend the live webcast > and join the prime developer group breaking into this new coding territory! > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > _______________________________________________ > Tora-develop mailing list > Tor...@li... > https://lists.sourceforge.net/lists/listinfo/tora-develop > > > > |