Menu

#893 Patch for https://svn.code.sf.net/p/tora/code/trunk/tora/CMakeLists.txt to streamline win32 builds

None
closed-fixed
win32 build (1)
5
2016-05-15
2015-01-11
Caysho
No

Please review the attached patch file for https://svn.code.sf.net/p/tora/code/trunk/tora/CMakeLists.txt
It adds the following:

IF(WIN32)
    set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE "${CMAKE_CURRENT_SOURCE_DIR}/src/Release")
    set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG "${CMAKE_CURRENT_SOURCE_DIR}/src/Debug")
    set CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELWITHDEBINFO "${CMAKE_CURRENT_SOURCE_DIR}/src/RelWithDebInfo")
ENDIF()

MESSAGE("CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE is:        " ${CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE})
MESSAGE("CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG is:          " ${CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG})
MESSAGE("CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELWITHDEBINFO is: " ${CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELWITHDEBINFO})

On Windows, it will force the build to be generated to the tora/src/CMAKE_BUILD_TYPE directory. For the RelWithDebInfo build, this means running make_msi.bat from tora\src\windows\installer\ will work with the correct relative path.

1 Attachments

Discussion

  • Ivan Brezina

    Ivan Brezina - 2015-01-12

    Is this intended for NMAKE generator based build?
    Is there a chance that this will break "Visual studio project" based build?

     
  • Caysho

    Caysho - 2015-01-14

    I tried it with NMAKE and VS 2010, both work.
    I do suggest this is verified by other people :)

    However, building with VS 2010 ignores these CMAKE macros, so I think the settings entered via cmake-gui need a modification.
    I have been working on revising the Win32 build instructions, and this is the last part I am working on.

     
  • Caysho

    Caysho - 2015-01-17

    I have finished working on the Win32 build instructions.
    I have attached the README.WINDOWS file for review.
    I do not use Step 13, the batch file breaks my PATH entries.

     

    Last edit: Caysho 2015-01-17
  • Caysho

    Caysho - 2015-01-17

    Next part to work on is getting all the required files together for testing as part of the build process.

     

    Last edit: Caysho 2015-01-17
  • Ivan Brezina

    Ivan Brezina - 2016-05-15
    • status: open --> closed-fixed
    • assigned_to: Ivan Brezina
    • Group: -->
     
  • Ivan Brezina

    Ivan Brezina - 2016-05-15

    fixed.

     

Log in to post a comment.