#881 toextrac.cpp fails to build on OS X 10.9

[Hanspeter Niederstrasser]

After applying the patch in [patches:#84], toextract.cpp fails with this error:

cd /sw/build.build/tora-2.1.3-1/tora-2.1.3/finkbuild/src && /sw/var/lib/fink/path-prefix-clang/c++   -DCMAKE_BUILD -DHAVE_CONFIG_H -DHAVE_DLFCN_H -DHAVE_UNISTD_H -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_SQL_LIB -DQT_THREAD_LIB -DQT_XML_LIB -DTOMONOLITHIC -DTO_NO_ORACLE -MD  -O3 -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -mmacosx-version-min=10.9 -I/sw/build.build/tora-2.1.3-1/tora-2.1.3/finkbuild/src -I/sw/build.build/tora-2.1.3-1/tora-2.1.3/src -isystem /sw/lib/qt4-mac/include -F/sw/lib/qt4-mac/lib -isystem /sw/lib/qt4-mac/include/QtGui -isystem /sw/lib/qt4-mac/include/QtXml -isystem /sw/lib/qt4-mac/include/QtSql -isystem /sw/lib/qt4-mac/include/QtNetwork -isystem /sw/lib/qt4-mac/lib/QtCore.framework/Headers -I/sw/build.build/tora-2.1.3-1/tora-2.1.3 -I/sw/build.build/tora-2.1.3-1/tora-2.1.3/finkbuild -I/sw/lib/qt4-mac/include/QtDesigner -I/sw/lib/qt4-mac/include/QtDeclarative -I/sw/lib/qt4-mac/include/QtScriptTools -I/sw/lib/qt4-mac/include/QtDBus -I/sw/lib/qt4-mac/include/QtOpenGL -I/sw/lib/qt4-mac/include/QtMultimedia -I/sw/lib/qt4-mac/include/QtXmlPatterns -I/sw/lib/qt4-mac/include/QtWebKit -I/sw/lib/qt4-mac/include/QtHelp -I/sw/lib/qt4-mac/include/QtUiTools -I/sw/lib/qt4-mac/include/QtTest -I/sw/lib/qt4-mac/include/QtScript -I/sw/lib/qt4-mac/include/QtSvg -I/sw/lib/qt4-mac/include/Qt3Support -I/sw/lib/qt4-mac/share/qt4/mkspecs/default -I/sw/build.build/tora-2.1.3-1/tora-2.1.3/src/loki/include -I/sw/build.build/tora-2.1.3-1/tora-2.1.3/src/otl -I/sw/lib/qt4-mac/include/Qsci    -DTOVERSION=\"2.1.3\" -DDEFAULT_PLUGIN_DIR=\"/sw/share/tora/\" -DQT -DSCI_LEXER -o CMakeFiles/TOra.dir/toextract.o -c /sw/build.build/tora-2.1.3-1/tora-2.1.3/src/toextract.cpp
In file included from /sw/build.build/tora-2.1.3-1/tora-2.1.3/src/toextract.cpp:42:
In file included from /sw/build.build/tora-2.1.3-1/tora-2.1.3/src/utils.h:47:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/list:178:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/algorithm:685:97: error: invalid operands to binary expression ('const toExtract::columnInfo' and 'const toExtract::columnInfo')
    _LIBCPP_INLINE_VISIBILITY bool operator()(const _T1& __x, const _T1& __y) const {return __x < __y;}
                                                                                            ~~~ ^ ~~~
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/list:2188:13: note: in instantiation of member function 'std::__1::__less<toExtract::columnInfo, toExtract::columnInfo>::operator()' requested here
        if (__comp(*--__e2, *__f1))
            ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/list:2174:5: note: in instantiation of function template specialization 'std::__1::list<toExtract::columnInfo, std::__1::allocator<toExtract::columnInfo> >::__sort<std::__1::__less<toExtract::columnInfo, toExtract::columnInfo> >' requested here
    __sort(begin(), end(), base::__sz(), __comp);
    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/list:2165:5: note: in instantiation of function template specialization 'std::__1::list<toExtract::columnInfo, std::__1::allocator<toExtract::columnInfo> >::sort<std::__1::__less<toExtract::columnInfo, toExtract::columnInfo> >' requested here
    sort(__less<value_type>());
    ^

[Mikhail T.]

Try this patch...

[Hanspeter Niederstrasser]

Yes. Along with the patch in [patches:#84], this patch allows tora-2.1.3 to completely build on OS X 10.9.

[Ivan Brezina]

applied. mac osx build should work with current 3.0 trunk now.

PS: I know it quite long time since you posted the patch. SF keep unsubcribing me from this forum.