Re: [Toppler-general] Patches

[Matthew C. <mc...@me...>]

On Sun, Apr 26, 2009 at 08:55:03AM +0200, Andreas R?ver wrote:
> If you want to can also do take over maintainership and do the release 
> yourself :)

I would be happy to do this.  
 
> > 2--The current version throws an uncaught exception from SDL_QUIT which
> > causes stuff (for example, under OS X it will pop up a little window
> > asking if you want to send a crash report to Apple).  I just changed it to
> > exit() (we can also chain the exception up the stack which is cleaner)
> 
> Whatever you think is right, but it would probably be better to solve the 
> cause for SDL_QUIT to throw the exception :)

It's thrown by the programmer.  The line is "throw new quit_action_class;"
but it's not caught anywhere.  Given the logic, exit() at that place
works just as well...
 
> > 3--The default window size is a touch small on my monitor, so I have added
> > support for resizable windows
> 
> What happens to the graphics when you resize the window? I don't understand 
> this...

I made the blitting scale (well, to be precise I'm using zoomSurface 
from the SDL_gfx lib, but it's fairly clean, we just need to import one file.)

I have a couple of glitches with the wave generation I still need to
fix but it largely works.

I was going to discuss this a bit however.  This does cause a bit of a
performance hit, may want to wrap it in #ifdefs.  (though the code is 
smart enought not do do anything if the window isn't resize).

It should be fast enough on any even vaguely modern CPU however.