From: Conal T. <con...@vu...> - 2008-04-15 02:45:36
|
On Sat, 2008-04-05 at 23:58 +1300, Xuân Baldauf wrote: > What the author of this expression presumably meant, is "is this topic > object in master mode?", and thus the author should have refactored > all occurrences of this expression to "t.isInMasterMode()" (or > "t.isBaseTopic()" when retaining the nomenclature). However, he did > not, and refactoring "t.getID().equals(t.getBaseTopic().getID())" into > "t.equalsByID(t.getBaseTopic())" was one step into this direction. I understand your analysis, but I don't see why, on the basis of that analysis, you did not just refactor it to "t.isBaseTopic()"? Or did you make this analysis after the earlier refactoring to use "t.equalsByID(t.getBaseTopic())"? -- Conal Tuohy New Zealand Electronic Text Centre www.nzetc.org |