Menu

#2475 listbox-28.2 duplication

obsolete: 8.6a1
closed-fixed
5
2008-07-26
2008-07-22
Don Porter
No

In listbox.test:

test listbox-28.2 {listbox -activestyle} {!win} {
destroy .l
listbox .l
.l cget -activestyle
} dotbox
test listbox-28.2 {listbox -activestyle} {win} {
destroy .l
listbox .l
.l cget -activestyle
} underline

Each test name should be used only
once. A simple change to deal with
this is to add .win to one of the test
names.

The !win constraint is using tcltest's
constraint expressions "feature" which
is really better off not used. Create
a named constraint with the meaning you
need instead.

I'll also suggest that the "win" constraint
may not be the best to use. The "win"
constraint asserts the tests are running
on some Windows system. The graphical
things getting tested here might be better
served by a constraint directly connected
to the [tk windowingsystem].

Assigning to patthoyts since the bug
originates with his commit, but feel
free to pass on to aniap if you like.

Discussion

  • Pat Thoyts

    Pat Thoyts - 2008-07-26

    Logged In: YES
    user_id=202636
    Originator: NO

    ok. done. Added a 'nonwin' constraint following the example from 'nonaqua'

     
  • Pat Thoyts

    Pat Thoyts - 2008-07-26
    • status: open --> closed-fixed