Menu ▾ ▴

#2288 package require Tk fails with makefile.vc

obsolete: 8.5a7
closed-fixed
Pat Thoyts
81. Portability (9)
9
2007-10-12
2007-06-19
Joe Mistachkin
No

The Tk makefile.vc uses $(TCL_PATCHLEVEL) but never defines it. This results in a pkgIndex.tcl that fails to load Tk.

The attached patch corrects the problem by introspecting the tcl.h file for the correct patch level using the new functionality provided by nmakehlp.c for this purpose.

Please review, as I intend to commit this change soon.

Discussion

  • Joe Mistachkin

    Joe Mistachkin - 2007-06-19

    v1 fix

     
    pkgIndexFix.diff

  • Pat Thoyts

    Pat Thoyts - 2007-10-12

    Logged In: YES
    user_id=202636
    Originator: NO

    I've committed a fix for this as part of a general re-work to extract the various version numbers from the tcl and tk headers using nmakehlp new features.

     

  • Pat Thoyts

    Pat Thoyts - 2007-10-12
    • status: open --> closed-fixed