- I find the FocusIn binding disturbing. If I move
accidently the cursor out o f the dialog after
painfully selecting some multiple items, everything is
lost (I have a FocusFollowsMouse window manager). I
think it's better to disable the FocusIn and FocusOut
bindings.
- There should be nop bindings for Control-B1-Motion,
Shift-B1-Motion, Control-Double-ButtonRelease-1 and
Shift-Double-ButtonRelease-1. If multiple items are
selected and while pressing the control key I do a
little horizontal movement, all items are deselected.
- In the IconList_Selection proc there is obviously a
[incr ind] missing, somewhere around line 107.
- Is there any reason why Curselection has a lowercase
"s" while DrawSelection has a uppercase "s"?
- In IconList_Arrange, a final call to
IconList_DrawSelection is missing. Otherwise the
selection will not be correctly redrawn if the window
is resized.
- If multiple directories are opened, day /a and /b,
then tkfbox.tcl seems to chdir first to /a and then
tries to open b in this directory, which of course
fails.
- All references to data(curItem) may be deleted, as
it's not used anymore.
Logged In: YES
user_id=79902
IconList_Selection and IconList_Arrange fixed and
Control-B1-Motion set to noop in CVS HEAD.
Can't work on focus handling (I'm marooned on WinXP) and
Shift-B1 bindings need more complex solution, so this bug is
not yet finished with.
Logged In: YES
user_id=79902
Shift-B1-Motion now seems reasonable. There are probably
some subtle faults there still, but even so.
Don't understand the 'multiple directories' problem yet.
Logged In: YES
user_id=79902
The directory issue is just the way things work; this is
paralleling the way things operate on other platforms
(selecting multiple things from multiple directories is just
plain hard, and requires a non-standard UI.)
All other issues are now fixed in CVS HEAD *except* for the
focus issue (which seems to be a consequence of the
FocusFollowsMouse model).
Logged In: YES
user_id=79902
I'm not a focus-follows-mouse-er any more; referring bug to
someone who might have more interest in this than me.