|
From: Jeff H. <je...@ac...> - 2006-12-14 21:57:48
|
Joe English wrote: > Proposed change: > > $nb remove $win > Unmaps the slave window $win but leave it managed. > If $win is not currently managed by $nb, do nothing. > > $nb add $win [... options ...] > Manage $win as a slave and add it to the end of the list > if it is not currently managed by $nb. Remap $win at > its previous position if it is currently managed by $nb > but unmapped. Do nothing if it is already mapped and managed. > > $nb forget $win > Unmap and unmanage $win. Do nothing if $win is not > currently managed by $nb. > > ... and the same thing for panedwindow widgets. > > [$nb remove $win] would do basically the same thing that > [$nb tab $win -state hidden] currently does (just implemented > differently); the latter could eventually be phased out. > > The only incompatibility would be that [$nb forget] would > only take window names, not arbitrary tab identifiers. It looks like remove and forget would only take window names. Any reason not to support tab ids as well? Is that because you do want to error on a tabId that isn't a window but isn't a valid id? I guess that would be harder to support and keep the semantics that double-forgetting shouldn't error. BTW, the reason that I encountered the bug is that in VFSE (Explorer-like app), if you hid the Folders List, one of the paths did forget twice. That would be harmless with grid/pack, but I got caught by panedwindow. Jeff |