#6 tcl 8.5 workaround

[Ben Collver]

A workaround patch is attached. On Fedora 9, TkMan gives the following error.

tab stop "-13" is not at a positive distance
tab stop "-13" is not at a positive distance
while executing
"$t tag configure info -tabs [list 0.3i $rm right]"
(procedure "manManTabSet" line 10)
invoked from within
"manManTabSet .man"
(command bound to event)

[Ben Collver]

workaround to prevent negative numbers

[Martin Tharby Jones]

A better fix:

--- gui.orig.tcl    2003-04-02 00:31:38.000000000 +0100
+++ gui.tcl 2016-01-11 15:52:40.235918773 +0000
@@ -745,6 +745,10 @@
 # so cols = (50/307)*562 = 91, want ~90, yay
    set repstr "ETRNIOASM          aaabcdeeeefghiijklmnnooprrsttuy"; set replen [string length $repstr]

+# Bring the application up to date by entering the event loop
+# so that winfo gives the correct size.

+        update
+
    set rm [expr {[winfo width $t]-2*[$t cget -padx]-10}]
    $t tag configure info -tabs [list 0.3i $rm right]
    $t tag configure census -tabs [list [expr {$rm-150}] right $rm right]

Tested with tcl/tk 8.5 & 8.6

[Ben Collver]

$ echo $MANPATH
/home/ben/local/man:/usr/local/share/man:/usr/local/man:/usr/share/man

$ uname -n
habit

$ cat /etc/fedora-release
Fedora release 9 (Sulphur)

$ rpm -q tcl tk rman xorg-x11-server-Xorg
tcl-8.5.2-2.fc9.i386
tk-8.5.2-1.fc9.i386
rman-3.2-8.fc9.i386
xorg-x11-server-Xorg-1.5.0-2.fc9.i386

[Tom Phelps]

Tk 8.5 make a couple changes that are incompatible with TkMan. The window manager reports a negative window size at startup, as reported above, and the text widget changed how text are formatted and tags are attached, so the text looks bad. For now, simply stick with Tcl/Tk 8.4.

[DorothyR]

I made a patch that addresses the most severe Tk 8.5 issues, because apparently I do that. Also added yet another place to look for the index database. 6 tcl files were changed.

[DorothyR]

Actually I see I've skipped right over Tk 8.5., and used Tk 8.6. Should work for both, but I'll see if I can compile Tk 8.5 and test it.

[Ben Collver]

I tried to apply this patch. First i had to convert the files from DOS to Unix style line endings.

tkman-2.2$ patch -p1 <../tkman_2.3a.patch 
patching file ANNOUNCE-tkman.txt
patching file Makefile
patching file gui.tcl
patching file manpath.tcl
patching file manual.html
Hunk #1 FAILED at 1555.
1 out of 1 hunk FAILED -- saving rejects to file manual.html.rej
patching file prefs.tcl
The next patch would delete the file retkman,
which does not exist!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
patching file tkman-help.tcl
Hunk #1 FAILED at 458.
1 out of 1 hunk FAILED -- saving rejects to file tkman-help.tcl.rej
patching file tkman.tcl
Hunk #2 FAILED at 1521.
Hunk #3 FAILED at 2255.
2 out of 3 hunks FAILED -- saving rejects to file tkman.tcl.rej

[DorothyR]

I ended up forking as a new project, tkreadman. See if https://sourceforge.net/projects/tkreadman/ works for you. That has the lineends converted, and the Makefile changed to make retkman, and things like that. You can file a bug over there if I blew it :-)

[Tom Phelps]

TkMan still works great with the version of Tcl/Tk listed in its requirements. You initiated a hostile takeover to get your 5 lines of patches accepted -- WTF? I see you also changed the license, which is illegal. Please delete tkreadman so I don't have to make formal complaints.

[DorothyR]

Oh, OK I'm sorry. I didn't mean to do a hostile takeover. I was just trying to be useful. I'll take it down.

[Tom Phelps]

Thank you for being cooperative.