Menu

#88 Are bundled self-tests supposed to work?

1.4.0
closed
None
4
2023-04-09
2016-07-12
Mikhail T.
No

As before, I'm seeing a fair number of bundled self-tests fail here. Before I dive into investigating, could somebody, please, confirm that the tests included in 1.4.6 release are reliable and all supposed to work?

For just one example, the bundled tkimg/tga/tests/hori.tga is broken -- even ImageMagick's display-utility fails to show open it citing "improper image header".

Thanks!

Discussion

  • Paul Obermeier

    Paul Obermeier - 2016-07-27

    You are right. Some of the tests fail.
    I will check and correct the test suite in the next days.
    Paul

     
  • Paul Obermeier

    Paul Obermeier - 2016-07-27
    • status: open --> accepted
    • assigned_to: Paul Obermeier
    • Priority: 1 --> 4
     
  • Mikhail T.

    Mikhail T. - 2017-12-31

    Trying to upgrade the FreeBSD port to version 1.4.7 and the situation with tests seems even worse than before:

    • Top-level Makefile invokes wish with argument all.tcl -- but such a script does not exist. The correct script-name seems to be all -- no suffix.
    • Top-level Makefile forgets to cd into the tests/ subdirectory -- and, consequently, the test-scriptlets can't find their test-files
    • A fair share of scriptlets still fails -- as reported originally. Not sure, if the failures are the same or not.

    Once again I ask for a confirmation: has someone done make test (or otherwise invoked the all script) and saw it run to completion cleanly?

    For example, my port tries to avoid using the graphics libraries bundled with the sources -- they should not be bundled to begin with, in my not so humble opinion. So the differences between test and actual images may be due to the port using the latest versions of libtiff, libjpeg (-turbo), etc.

    But if the tests are still -- 18 months later -- known to be broken, I will not investigate the test-failures here. Please, advise. Thank you!

     

    Last edit: Mikhail T. 2017-12-31
  • Mikhail T.

    Mikhail T. - 2017-12-31

    Here is the test-log output...

     
  • Paul Obermeier

    Paul Obermeier - 2018-01-02

    Hi Mikhail,

    thanks for testing and your report.
    I typically only run the automatic tests by going into the (now) global "tests" directory and executing "tclsh all".
    I have now updated the configure and Makefiles, so that a "make test" should work, too. Tested on Windows and SuSE Linux. Please check, if the new structure works for you.
    Note, that you have to do a "make install" before performing the tests, because the final pkgIndex.tcl file is generated at the installation step.

    Regards,
    Paul

     
  • Paul Obermeier

    Paul Obermeier - 2023-04-09
    • status: accepted --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB