[Tkdiff-discuss] RE: redo your patch?

[John K. <jo...@kl...>]

Michael,

Got your patched version into the system as revision 1.11...  I went =
ahead
and changed the version string to 4.0b1 (the switch to 4.0 is to get =
away
from the strange [IMHO] numbering we've been using :-)).  But anyway, I =
love
your changes!  Having a visual indication of the difference, inline, is =
very
cool.  Nicely done!

Anybody who wants to take a look can grab the latest via anonymous =
CVS...

I propose that we play around with this version for a while, then ship =
it as
4.0 at some point in the near future.

Thoughts, anyone?

John

--
John Klassa / jo...@kl...

Please use this address for all personal correspondence.  Thanks!


> -----Original Message-----
> From: Michael D. Beynon [mailto:be...@ya...]
> Sent: Monday, May 12, 2003 8:33 AM
> To: John Klassa
> Subject: Re: redo your patch?
>=20
> I reapplied my inline diff changes to cvs 1.10.  I am not sure how you
> want me to send the revised version, so I am simply attaching it to
> this message.  I don't think I can directly update the version in cvs.
>=20
> I did find a problem on my machine (rh8.0 with tcl/tk 8.3.3-74) where
> there is a new test to determine what color a selection is (selcolor)
> by creating a dummy entry widget, and selecting the text in it, and
> using configure to determine the color.  The problem is I get a very
> dark gray, which is nearly indistinguishable from the unselected case.
> This means all the checkboxes in the menus look like they are
> unselected.  I simply hardcoded this to the default color I get for a
> checkbox.
>=20
> Mike.
>=20
> --- John Klassa <jo...@kl...> wrote:
> > Hi Michael,
> >
> > Not sure if the sf patch mechanism feeds back to you when you submit
> > a
> > patch, and there's a subsequent comment, but I thought I'd contact
> > you
> > directly just in case not.
> >
> > I applied your patch on top of the previous one in the queue
> > (Dorothy's),
> > and got failures on 5 of 30 hunks.  Rather than have me hose
> > something,
> > could I ask you to re-do your changes, on top of the latest that's =
in
> > CVS
> > (1.10, I believe) -- which is basically just the old 3.0.9 with
> > Dorothy's
> > patch thrown in?
> >
> > Thanks,
> > John
> >
> > --
> > John Klassa / jo...@kl...
> >
> > Please use this address for all personal correspondence.  Thanks!
> >
> >
>=20
> __________________________________
> Do you Yahoo!?
> The New Yahoo! Search - Faster. Easier. Bingo.
> http://search.yahoo.com