Menu
▾
▴
#97 highlight not working for last line difference
Highlight is not working for the last line when comparing files with differences on 16 lines. File 1 could for example contain 16 lines with a single "s" character and file 2 contain 16 lines with "sa" string. In the diff window only 15 "a" characters are highlighted. I tested also some other line counts and found the same issue with line counts 31 and 61.
My, what sharp little eyes you have!
All kidding aside, you appear to be correct, although it may take a little time to work out the exact triggering situation (eg. is it ANY 16-line hunk, the last physical hunk, only at file EOL, etc.). The 61 suggests its not some "power-of-2" related issue, but we will find out eventually. I applaud your industriousness for finding even the beginning of a "pattern".
Will report more after I do some investigating. Standby.
OK. Turns out there were multiple issues (almost a wonder it functioned as well as it did) but nevertheless the fix(es) are now completed. For the record, the OBSERVED issue only involved Diff hunks whose "highlight-able" size (in lines) was SOME multiple of 5 PLUS 1; whereby the "plus 1" (aka that FINAL line) failed to get marked-up. As this is rather difficult to anticipate and CLEARLY data dependent, an updated release will be forthcoming shortly. Thank you again, both for spotting and reporting it. It had existed this way for several releases. This report will remain open until the release is made, at which time 'closing' it should cause an Email notification, effectively notifying the new release is ready for you to install.