I think it is not a good practice to use implicit != 0 in non-boolean comparison expressions like those in assertions or null-pointer checks.
It is also reported as warning by compiler.
Potentially, they are bugs.
I knod TinyXML is multiplatform eg. I use it on Pocket PC but I think CoreLinux C++ standard is a good foundation for best practice. What do you think?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I think it is not a good practice to use implicit != 0 in non-boolean comparison expressions like those in assertions or null-pointer checks.
It is also reported as warning by compiler.
Potentially, they are bugs.
Constructions like this
const char* p = stamp;
//...
assert( stamp );
should be changed to
const char* p = stamp;
//...
assert( NULL != stamp );
as the best practice.
I knod TinyXML is multiplatform eg. I use it on Pocket PC but I think CoreLinux C++ standard is a good foundation for best practice. What do you think?