Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[63541] trunk/lib/smarty_tiki

[Jean-Marc L. <jea...@gm...>]

On Wed, Aug 23, 2017 at 5:06 PM, Cloutier, Philippe (DGARI-Consultant) <
Phi...@me...> wrote:

> >De : Jean-Marc Libs [mailto:jea...@gm...]
> >Envoyé : 22 août 2017 19:49
> >À : CVS/SVN commits information <tik...@li...>;
> Tikiwiki developers <tik...@li...>
> >Objet : Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[63541]
> trunk/lib/smarty_tiki
> >
> >Thanks Marc,
> >>I guess you have this section in mind:
> >>Can I strip out the copyrights on Open Source code and put in my own?
> >>Definitely not! This isn't even about Open Source, really: in general,
> you should not remove a valid copyright notice, no matter what license it
> specifies. Copyright notices are legal notices; they are also a source of
> information about the provenance of source code, and if that information is
> stripped out, recipients of downstream copies have no easy way to
> rediscover it.
> >
> >So I was not correct, I thought we could.
> >Still, the issue is there: we did not actually strip anything out anyway.
> The attribution to the initial author is still and has always been there.
> >But now that Chealer has stripped our copyright notice there is
> absolutely no reference to any license left.
> >What do we expect people who receive these files to do with them?
> >Where did we get the idea that this file was actually distributed under
> the terms of the LGPL?
>
>
> I don't see such an issue, but this is drifting from this thread's topic.
> If you are concerned that one of the original files was not distributed
> under the LGPL, please start a thread on tikiwiki-devel mentioning which
> one that is.
>
> >Chealer says they are smarty files but I found no indication that they
> are on the site they come from: http://smarty.incutio.com/?page=FrontPage
> :-(
>
> I am not sure I understand you right, but if you are saying that some of
> the original files were taken from the website and are not actually part of
> Smarty, I was speaking in general and did not mean to speak specifically
> about the Smarty library. There is visibly at least 1 file which is indeed
> not from the Smarty library, but the issue remains the same.
>
>
When you said on aust 15th «Correct, but some of these "Tiki files" are
copies of Smarty files (as indicated in these files) we made to avoid
modifying the plugins directly in the upstream folder.», I thought you knew
what you were talking about, which you now change into «I was speaking in
general».

Random commits backed with no research or understanding of the subject are
not really helping Tiki :-(


>
> >Cheers,
> >Jyhem
> >
> >>On Wed, Aug 16, 2017 at 9:19 PM, Marc Laporte <ma...@ma...>
> wrote:
> >>https://opensource.org/faq#preserve-copyright-notices
> >>
> >>On Wed, Aug 16, 2017 at 5:10 AM, Jean-Marc Libs <jea...@gm...>
> wrote:
> >>> They are LGPL, we are LGPL, we can modify them and distribute them
> under the
> >>> LGPL and this includes a copyright header.
> >>> People get these from Tiki, not from smarty and we have to tell them
> that
> >>> they are LGPL.
> >>>
> >>> I still don't get why you removed the copyright notice.
> >>>
> >>> This is not BSD v1 licence with a requirement to mention all successive
> >>> contributors
> >>>
> >>> On Tue, Aug 15, 2017 at 3:42 PM, Cloutier, Philippe (DGARI-Consultant)
> >>> <Phi...@me...> wrote:
> >>>>
> >>>> No, Smarty is under the LGPL.
> >>>> These notices were added by commits which automatically added a
> copyright
> >>>> header to all PHP files, failing to check whether we actually have
> copyright
> >>>> on them. The files I modified come from Smarty.
> >>>>
> >>>> >De : Jean-Marc Libs [mailto:jea...@gm...]
> >>>> >Envoyé : 15 août 2017 04:03
> >>>> >À : Filipus Klutiero <ch...@gm...>
> >>>> >Cc : CVS/SVN commits information <tik...@li...
> >
> >>>> >Objet : Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[63541]
> >>>> > trunk/lib/smarty_tiki
> >>>> >
> >>>> >Are you saying smarty does not have a LGPL-compatible license?
> >>>> >
> >>>> >On Tue, Aug 15, 2017 at 3:59 AM, Filipus Klutiero <ch...@gm...
> >
> >>>> > wrote:
> >>>> >Correct, but some of these "Tiki files" are copies of Smarty files
> (as
> >>>> > indicated in these files) we made to avoid modifying the plugins
> directly in
> >>>> > the upstream folder.
> >>>> >
> >>>> >
> >>>> >>On 2017-08-14 17:33, Jean-Marc Libs wrote:
> >>>> >>My undestanding is, smarty files are in
> >>>> >>vendor_bundled/vendor/smarty/
> >>>> >>The files in lib/smarty_tiki/ are Tiki files for expanding and
> adapting
> >>>> >> smarty to Tiki.
> >>>> >>Unless I'm wrong, this should be rolled back
> >>>> >>Jyhem
> >>>> >>
> >>>> >>>On Mon, Aug 14, 2017 at 10:24 PM, chealer--- via Tikiwiki-cvs
> >>>> >>> <tik...@li...> wrote:
> >>>> >>>Revision: 63541
> >>>> >>>          http://sourceforge.net/p/tikiwiki/code/63541
> >>>> >>>Author:   chealer
> >>>> >>>Date:     2017-08-14 20:24:27 +0000 (Mon, 14 Aug 2017)
> >>>> >>>Log Message:
> >>>> >>>-----------
> >>>> >>>[REF] Stop claiming copyright on Smarty files
> >>>> >>>
> >>>> >>>Modified Paths:
> >>>> >>>--------------
> >>>> >>>    trunk/lib/smarty_tiki/block.repeat.php
> >>>> >>>    trunk/lib/smarty_tiki/compiler.assign.php
> >>>> >>>    trunk/lib/smarty_tiki/function.html_select_time.php
> >>>> >>>    trunk/lib/smarty_tiki/function.popup.php
> >>>> >>>    trunk/lib/smarty_tiki/modifier.escape.php
> >>>> >>>    trunk/lib/smarty_tiki/modifier.truncate.php
> >>>> >>>
> >>>> >>>Modified: trunk/lib/smarty_tiki/block.repeat.php
> >>>> >>>=========================================================
> ==========
> >>>> >>>--- trunk/lib/smarty_tiki/block.repeat.php      2017-08-14
> 20:09:41 UTC
> >>>> >>> (rev 63540)
> >>>> >>>+++ trunk/lib/smarty_tiki/block.repeat.php      2017-08-14
> 20:24:27 UTC
> >>>> >>> (rev 63541)
> >>>> >>>@@ -1,8 +1,4 @@
> >>>> >>> <?php
> >>>> >>>-// (c) Copyright 2002-2016 by authors of the Tiki Wiki CMS
> Groupware
> >>>> >>> Project
> >>>> >>>-//
> >>>> >>>-// All Rights Reserved. See copyright.txt for details and a
> complete
> >>>> >>> list of authors.
> >>>> >>>-// Licensed under the GNU LESSER GENERAL PUBLIC LICENSE. See
> >>>> >>> license.txt for details.
> >>>> >>> // $Id$
> >>>> >>>
> >>>> >>> /**
> >>>> >>>
> >>>> >>>Modified: trunk/lib/smarty_tiki/compiler.assign.php
> >>>> >>>=========================================================
> ==========
> >>>> >>>--- trunk/lib/smarty_tiki/compiler.assign.php   2017-08-14
> 20:09:41 UTC
> >>>> >>> (rev 63540)
> >>>> >>>+++ trunk/lib/smarty_tiki/compiler.assign.php   2017-08-14
> 20:24:27 UTC
> >>>> >>> (rev 63541)
> >>>> >>>@@ -1,8 +1,4 @@
> >>>> >>> <?php
> >>>> >>>-// (c) Copyright 2002-2016 by authors of the Tiki Wiki CMS
> Groupware
> >>>> >>> Project
> >>>> >>>-//
> >>>> >>>-// All Rights Reserved. See copyright.txt for details and a
> complete
> >>>> >>> list of authors.
> >>>> >>>-// Licensed under the GNU LESSER GENERAL PUBLIC LICENSE. See
> >>>> >>> license.txt for details.
> >>>> >>> // $Id$
> >>>> >>>
> >>>> >>> /**
> >>>> >>>
> >>>> >>>Modified: trunk/lib/smarty_tiki/function.html_select_time.php
> >>>> >>>=========================================================
> ==========
> >>>> >>>--- trunk/lib/smarty_tiki/function.html_select_time.php 2017-08-14
> >>>> >>> 20:09:41 UTC (rev 63540)
> >>>> >>>+++ trunk/lib/smarty_tiki/function.html_select_time.php 2017-08-14
> >>>> >>> 20:24:27 UTC (rev 63541)
> >>>> >>>@@ -1,8 +1,4 @@
> >>>> >>> <?php
> >>>> >>>-// (c) Copyright 2002-2016 by authors of the Tiki Wiki CMS
> Groupware
> >>>> >>> Project
> >>>> >>>-//
> >>>> >>>-// All Rights Reserved. See copyright.txt for details and a
> complete
> >>>> >>> list of authors.
> >>>> >>>-// Licensed under the GNU LESSER GENERAL PUBLIC LICENSE. See
> >>>> >>> license.txt for details.
> >>>> >>> // $Id$
> >>>> >>>
> >>>> >>> //this script may only be included - so its better to die if
> called
> >>>> >>> directly.
> >>>> >>>
> >>>> >>>Modified: trunk/lib/smarty_tiki/function.popup.php
> >>>> >>>=========================================================
> ==========
> >>>> >>>--- trunk/lib/smarty_tiki/function.popup.php    2017-08-14
> 20:09:41 UTC
> >>>> >>> (rev 63540)
> >>>> >>>+++ trunk/lib/smarty_tiki/function.popup.php    2017-08-14
> 20:24:27 UTC
> >>>> >>> (rev 63541)
> >>>> >>>@@ -1,8 +1,4 @@
> >>>> >>> <?php
> >>>> >>>-// (c) Copyright 2002-2016 by authors of the Tiki Wiki CMS
> Groupware
> >>>> >>> Project
> >>>> >>>-//
> >>>> >>>-// All Rights Reserved. See copyright.txt for details and a
> complete
> >>>> >>> list of authors.
> >>>> >>>-// Licensed under the GNU LESSER GENERAL PUBLIC LICENSE. See
> >>>> >>> license.txt for details.
> >>>> >>> // $Id$
> >>>> >>>
> >>>> >>> /**
> >>>> >>>
> >>>> >>>Modified: trunk/lib/smarty_tiki/modifier.escape.php
> >>>> >>>=========================================================
> ==========
> >>>> >>>--- trunk/lib/smarty_tiki/modifier.escape.php   2017-08-14
> 20:09:41 UTC
> >>>> >>> (rev 63540)
> >>>> >>>+++ trunk/lib/smarty_tiki/modifier.escape.php   2017-08-14
> 20:24:27 UTC
> >>>> >>> (rev 63541)
> >>>> >>>@@ -1,8 +1,5 @@
> >>>> >>> <?php
> >>>> >>>-// (c) Copyright 2002-2016 by authors of the Tiki Wiki CMS
> Groupware
> >>>> >>> Project
> >>>> >>>-//
> >>>> >>>-// All Rights Reserved. See copyright.txt for details and a
> complete
> >>>> >>> list of authors.
> >>>> >>>-// Licensed under the GNU LESSER GENERAL PUBLIC LICENSE. See
> >>>> >>> license.txt for details.
> >>>> >>>+
> >>>> >>> // $Id$
> >>>> >>>
> >>>> >>> /**
> >>>> >>>
> >>>> >>>Modified: trunk/lib/smarty_tiki/modifier.truncate.php
> >>>> >>>=========================================================
> ==========
> >>>> >>>--- trunk/lib/smarty_tiki/modifier.truncate.php 2017-08-14
> 20:09:41 UTC
> >>>> >>> (rev 63540)
> >>>> >>>+++ trunk/lib/smarty_tiki/modifier.truncate.php 2017-08-14
> 20:24:27 UTC
> >>>> >>> (rev 63541)
> >>>> >>>@@ -1,8 +1,4 @@
> >>>> >>> <?php
> >>>> >>>-// (c) Copyright 2002-2016 by authors of the Tiki Wiki CMS
> Groupware
> >>>> >>> Project
> >>>> >>>-//
> >>>> >>>-// All Rights Reserved. See copyright.txt for details and a
> complete
> >>>> >>> list of authors.
> >>>> >>>-// Licensed under the GNU LESSER GENERAL PUBLIC LICENSE. See
> >>>> >>> license.txt for details.
> >>>> >>> // $Id$
> >>>> >>>
> >>>> >>> /**
> >>>> >>
> >>>> >>--
> >>>> >>Filipus Klutiero
> >>>> >>http://www.philippecloutier.com
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Tikiwiki-cvs mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>