Menu
▾
▴
[Tiki-devel] Tiki coding conventions [was Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[60884] trunk/lib]
|
From: Jonny B. <jo...@ti...> - 2017-01-16 19:17:13
|
Hi Victor and all (moving this from csv to dev list) The conventions in Tiki have always been "variable" and i've always gone with what the surrounding code looks most like, but yes, there are libraries that are already mixed (trackers, file gals etc) where people haven't done this - and in those cases, as with new files and revamps as Luci suggested, i guess we should go with camelCase where it makes sense... (although i would go with a majority thing so will continue to use snake_case for those old libs with only a few camels...) Certainly everything inside lib/core should be camel style i think and should stay that way. While we're looking at this sort of thing, any feelings now about our tabs instead of spaces exception these days? I seem to remember when i last suggested we change there were a couple of people on this list who were fiercely against it? (spaces never go wrong, tabs often do) Discuss! :) jonny > On 16 Jan 2017, at 18:10, Victor Emanouilov <ti...@em...> wrote: > > I have pondered this myself - things get even more confusing for large > libs like trackerlib or service controllers where we have a mix - large > set of snake_case vs small set of camelCased functions. Do we have an > agreement as to what case should the new functions be in those files? > > Regards, > Victor > > On 01/16/2017 04:13 PM, Jonny Bradley wrote: >> >> +1 for following the convention per file. Tiki has too much code (and not enough coders) to change everything over from snake_case to camelCase everywhere. >> >> I suggest we add another exception to the Zend standards? >> >> jb >> >> >> >>> On 16 Jan 2017, at 14:07, Brendan Ferguson <drs...@gm...> wrote: >>> >>> I hope all the other authors of the functions in that file get arrested too! ;) >>> >>> Yup. I was caught as well! >>> >>> Its good though. I was also just following the conventions in the file. I normally use that zend convention in my own code, just cause I like it :) Now that I know this tiki convention, I can keep a more watchful eye on it. >>> >>> Brendan >>> >>> >>>> Can you send me a link? I just followed the convention of the already existing functions in the headerlib... >>>> >>>> luci >>>> >>>> >>>>> Other than that, I find this function counter-intuitive. Please either: >>>>> • Document >>>>> • Rename to something like "setRawHTML" >>>>> • Concatenate the argument to $this->rawhtml rather than overwriting >>>>> >>>>> >>>>> -- >>>>> Filipus Klutiero >>>>> >>>>> http://www.philippecloutier.com >>>>> >>>>> >>>>> ------------------------------------------------------------ >>>>> ------------------ >>>>> Developer Access Program for Intel Xeon Phi Processors >>>>> Access to Intel Xeon Phi processor-based developer platforms. >>>>> With one year of Intel Parallel Studio XE. >>>>> Training and support from Colfax. >>>>> Order your platform today. >>>>> http://sdm.link/xeonphi >>>>> >>>>> >>>>> ______________________________ >>>>> _________________ >>>>> Tikiwiki-cvs mailing list >>>>> >>>>> Tik...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >>>> >>>> ------------------------------------------------------------------------------ >>>> Developer Access Program for Intel Xeon Phi Processors >>>> Access to Intel Xeon Phi processor-based developer platforms. >>>> With one year of Intel Parallel Studio XE. >>>> Training and support from Colfax. >>>> Order your platform today. http://sdm.link/xeonphi >>>> _______________________________________________ >>>> Tikiwiki-cvs mailing list >>>> Tik...@li... >>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >>> >>> ------------------------------------------------------------------------------ >>> Developer Access Program for Intel Xeon Phi Processors >>> Access to Intel Xeon Phi processor-based developer platforms. >>> With one year of Intel Parallel Studio XE. >>> Training and support from Colfax. >>> Order your platform today. http://sdm.link/xeonphi_______________________________________________ >>> Tikiwiki-cvs mailing list >>> Tik...@li... >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >> >> ------------------------------------------------------------------------------ >> Developer Access Program for Intel Xeon Phi Processors >> Access to Intel Xeon Phi processor-based developer platforms. >> With one year of Intel Parallel Studio XE. >> Training and support from Colfax. >> Order your platform today. http://sdm.link/xeonphi >> _______________________________________________ >> Tikiwiki-cvs mailing list >> Tik...@li... >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > _______________________________________________ > Tikiwiki-cvs mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs |