Re: [Tiki-devel] Replacing our JS minifier

[Jean-Marc L. <jea...@gm...>]

+1

On Wed, Dec 7, 2016 at 6:53 PM, Jonny Bradley <jo...@ti...> wrote:
> Hi Victor
>
> Thanks for investigating this (also thanks for the fixes on profiles export i saw going through, looks like good work :)
>
> Your reasoning seems sound and i couldn't find any better looking ones. I guess also being able to do CSS is extra useful, as it looks like our current one (vendor_extra/pear/Minify/CSS.php) is also similarly ancient and no doubt very out of date.
>
> So i reckon +1, yes please go ahead and (in a day or two) add this to 16.x because currently 16.0 is broken in this respect (you can't use minify and codemirror at the same time) and we can have a look at the CSS bit too once that's working (maybe for 17?)
>
> Thanks again,
>
> jonny
>
>
>
>
>> On 7 Dec 2016, at 15:46, Victor Emanouilov <ti...@em...> wrote:
>>
>> Hi all,
>>
>> Currently tiki uses https://github.com/rgrove/jsmin-php/ to minify JS
>> assets if that preference is set. As you can see, it is pretty
>> old/outdated package not maintained anymore and also Jonny recently
>> found issues with minifying codemirror files. I think it chunks on
>> certain valid JS code missing semicolons and things like that.
>>
>> After some research I found this as a suitable PHP-based replacement:
>>
>> https://packagist.org/packages/matthiasmullie/minify
>>
>> Some pros here:
>>
>> - simple/php based - does what we aim for (minifying) and not things
>> like asset pipelining which are bundle together in other projects
>>
>> - nice github rating with stars/forks/releases/commits history
>>
>> - frequently maintained and nice code coverage with tests
>>
>> - author participates in and supports other open source software
>> including wikipedia
>>
>> - supports css minification which we could use to enhance the available
>> tiki js minification feature
>>
>> This is a proposal. If anyone see any issue or has a better proposal,
>> please share, so we can update accordingly.
>>
>> Thanks!
>>
>> Victor
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Developer Access Program for Intel Xeon Phi Processors
>> Access to Intel Xeon Phi processor-based developer platforms.
>> With one year of Intel Parallel Studio XE.
>> Training and support from Colfax.
>> Order your platform today.http://sdm.link/xeonphi
>> _______________________________________________
>> TikiWiki-devel mailing list
>> Tik...@li...
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>
>
> ------------------------------------------------------------------------------
> Developer Access Program for Intel Xeon Phi Processors
> Access to Intel Xeon Phi processor-based developer platforms.
> With one year of Intel Parallel Studio XE.
> Training and support from Colfax.
> Order your platform today.http://sdm.link/xeonphi
> _______________________________________________
> TikiWiki-devel mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel