Re: [Tiki-devel] Smarty update

[Jonny B. <jo...@ti...>]

Stuck, so added https://github.com/smarty-php/smarty/issues/296

jb

> On 24 Sep 2016, at 13:50, Jonny Bradley <jo...@ti...> wrote:
> 
> Hi all
> 
> I've been trying to get us updated to the latest release of smarty for tiki 16.x but am stuck, again (i did try for tiki 15 but ran out of time).
> 
> I have it partially working, all apart from one change which i don't seem to be able to get around, so any clues or new ideas would be really helpful.
> 
> The problem appeared for me in the list friends module, which uses {service_inline controller=social action=list_friends} in templates/modules/mod-friend_list.tpl
> 
> This uses \Services_Broker::internalRender which results in doing a smarty fetch on 
> 
>    "extends:layouts/internal/layout_view.tpl|social/list_friends.tpl"
> 
> and in smarty 3.1.21 using this "resource extends" method overrides the {extends} tag in the list_friends.tpl template which means it just renders the content block, and doesn't include the whole page.
> 
> However, in smarty >= 3.1.28 it totally ignores the fetch resource extends at lib/core/Services/Broker.php:159 and uses the main layout_view.tpl in templates/social/list_friends.tpl:1 (if i rename that one to try and load a file that doesn't exist i get an error message, otherwise the righthand module zone contains the whole page recursively.
> 
> So somewhere around 3.1.23 a lot of stuff changes and between then (3.1.22 doesn't seem to exist) and 3.1.28 i can't seem to get tiki to work with it at all!
> 
> So something very non-minor seems to have changed in a minor update, so are we stuck on v 3.1.21 forever? Seems like a bad thing...
> 
> I'll keep noodling at it, and probably will try and post something in their forums, but i thought i'd check in here first in case i missed something easy? ;)
> 
> TIA
> 
> jonny
> 
> 
> ------------------------------------------------------------------------------
> _______________________________________________
> TikiWiki-devel mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>