Menu
▾
▴
Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[51536] branches/13.x/lib/prefs/theme.php
|
From: lindon <li...@ti...> - 2014-05-30 02:49:33
|
Seems like simpler would be better along the lines of what luci suggested, but I admit to not really understanding what #2 is or what benefits it might have. Regards, lindon On May 29, 2014, at 11:35 AM, Gary Cunningham-Lee <ga...@cu...> wrote: > Hi, > > The reason for my suggestion was that I was thinking there might be up > to three scenarios for a theme - 1) a bootstrap.css-equivalent file, so > no need to use the default bootstrap.css; this would be any file in the > styles directory, 2) a theme that, like our old legacy themes, would use > the bundled bootstrap.css and tiki.css like we used to use lite.css, > layout.css and design.css and just override some theme details, and 3) a > custom theme in another location. (I didn't include "use the default > bootstrap.css" in that list of scenarios - I guess this should be > offered as a theme option but don't see the usefulness of it really > except for the novelty of seeing how Tiki looks with the Bootstrap default.) > > This was my thinking in the beginning, but maybe "2)" isn't a likely > scenario. This would mean the selectors and their labels could be simpler. > > -- Gary > > > On 5/29/2014 11:01 PM, luciash wrote: >> Hi, >> >> I do not think this is good label for newbie users. >> >> Why do we need to distinguish them at all ? Why not just one label >> "Choose Theme" (where you choose from all available themes where one >> will have "Bootstrap default" label) and then a checkbox for "Custom >> theme location" ? >> >> luci >> >> >> On 05/29/2014 02:52 PM, Gary Cunningham-Lee wrote: >>> Hi >>> >>> I've also been thinking the label "legacy themes" wasn't accurate and >>> should be changed, because any theme in styles/ can be selected. Your >>> change to "legacy styles + Bootswatch themes" is accurate, but I think >>> maybe the label should simply be something like "Installed >>> bootstrap.css-equivalent theme". The point is that these theme files are >>> in the styles directory and they are bootstrap.css variants (so have all >>> the needed CSS rules). (The old legacy themes that don't meet that >>> criteria will be removed.) >>> >>> If the label is "Installed bootstrap.css-equivalent theme", this >>> indicates that the site admin can upload his/her own such theme into >>> styles and it can be chosen with this selector (as themes were added and >>> chosen pre-tiki13). >>> >>> What do you think about this label text change? >>> >>> -- Gary >>> >>> On 5/29/2014 6:36 PM, xa...@us... wrote: >>>> Revision: 51536 >>>> http://sourceforge.net/p/tikiwiki/code/51536 >>>> Author: xavidp >>>> Date: 2014-05-29 09:36:28 +0000 (Thu, 29 May 2014) >>>> Log Message: >>>> ----------- >>>> [FIX]Rename label 'Use legacy styles' to refer also to styles taken from Bootswatch.com. Fix the display to understand that they are 3 options one below the other. Add help url for more info (nice!: icon changes automagically when 'help=URL' is added to the preference params). >>>> >>>> Modified Paths: >>>> -------------- >>>> branches/13.x/lib/prefs/theme.php >>>> >>>> Modified: branches/13.x/lib/prefs/theme.php >>>> =================================================================== >>>> --- branches/13.x/lib/prefs/theme.php 2014-05-29 09:17:36 UTC (rev 51535) >>>> +++ branches/13.x/lib/prefs/theme.php 2014-05-29 09:36:28 UTC (rev 51536) >>>> @@ -10,7 +10,7 @@ >>>> $themes = [ >>>> 'default' => tr('Bootstrap Default'), >>>> 'custom' => tr('Custom theme location, see below'), >>>> - 'legacy' => tr('Use legacy styles'), >>>> + 'legacy' => tr('Use legacy styles + styles from Bootswatch.com'), >>>> ]; >>>> >>>> foreach (glob("themes/*/css/tiki.css") as $css) { >>>> @@ -23,10 +23,11 @@ >>>> return array( >>>> 'theme_active' => array( >>>> 'name' => tr('Theme'), >>>> - 'description' => tr('Select the theme to be used.').' '.tr('You can choose from many new themes taken from Bootswatch.com if you select <em>Theme: <b>Use legacy styles</b> > Style: <b>bootswatch_themes</b> > Theme options: <code>Amelia</code>, <code>Cerulean</code>, <code>Cosmo</code>, ..., <code>Yeti</code></em>'), >>>> + 'description' => tr('Select the theme to be used.').' '.tr('You can choose from many new themes taken from Bootswatch.com if you select <ul><li><em>Theme: <b>Use legacy styles + styles from Bootswatch.com</b></li><li>Style: <b>bootswatch_themes</b></li><li>Theme options: <code>Amelia</code>, <code>Cerulean</code>, <code>Cosmo</code>, ..., <code>Yeti</code></li></ul></em>'), >>>> 'type' => 'list', >>>> 'default' => 'default', >>>> 'options' => $themes, >>>> + 'help' => 'Tiki13#Themes', >>>> ), >>>> 'theme_custom' => array( >>>> 'name' => tr('Custom theme location'), >>>> >>>> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Time is money. Stop wasting it! Get your web API in 5 minutes. >>>> www.restlet.com/download >>>> http://p.sf.net/sfu/restlet >>>> _______________________________________________ >>>> Tikiwiki-cvs mailing list >>>> Tik...@li... >>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >>>> >>> >>> ------------------------------------------------------------------------------ >>> Time is money. Stop wasting it! Get your web API in 5 minutes. >>> www.restlet.com/download >>> http://p.sf.net/sfu/restlet >>> _______________________________________________ >>> Tikiwiki-cvs mailing list >>> Tik...@li... >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >> >> >> ------------------------------------------------------------------------------ >> Time is money. Stop wasting it! Get your web API in 5 minutes. >> www.restlet.com/download >> http://p.sf.net/sfu/restlet >> _______________________________________________ >> Tikiwiki-cvs mailing list >> Tik...@li... >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >> > > > ------------------------------------------------------------------------------ > Time is money. Stop wasting it! Get your web API in 5 minutes. > www.restlet.com/download > http://p.sf.net/sfu/restlet > _______________________________________________ > Tikiwiki-cvs mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs |