Menu
▾
▴
Re: [Tiki-devel] Fwd: <br> vs <br /> [was Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[42242] trunk/templates]
|
From: Gary Cunningham-L. <ga...@cu...> - 2013-02-27 14:27:22
|
If the proposal gets the votes, I can do the editing. -- Gary On 27/02/2013 13:06, Marc Laporte wrote: > Here is a reminder of a proposal: > http://dev.tiki.org/Mass+operations+to+do+after+the+Semi-automatic+merging+period > > Do we have more votes? And if enough votes, someone to manage it? > > Thanks! > > > ---------- Forwarded message ---------- > From: luciash <lu...@ti...> > Date: Sun, Jul 8, 2012 at 12:24 PM > Subject: Re: [Tiki-devel] <br> vs <br /> [was Re: [Tikiwiki-cvs/svn] > SF.net SVN: tikiwiki:[42242] trunk/templates] > To: tik...@li... > > > fully agreed > > more later, busy now ;) > > On 8.7.2012 5:23, Gary Cunningham-Lee wrote: >> Hi, >> >> Actually I meant both: the br tags that I removed were redundant because >> the containing div had a clearfix class (or one could be added), and >> also when br tags are used, they can be simplified. You're right that >> both forms of br are valid, but when I come across them and am editing, >> I tend to want to simplify them. >> >> If we are "html5-izing" the code, maybe it'd be good to find and replace >> all the tags that could be simplified - br, img, etc. - but mostly for >> code beauty and consistency than for practical effect of file size >> reduction. Maybe this could be done along with any other code practice >> updates we want to do regarding html5. >> >> I don't know how many cases there are of bad-semantics br tags. The ones >> that I found were having a bad effect on the visual display. It'd be >> good to agree on some guidelines (do we have already? - I don't know >> offhand) about br tags, and also p tags used for layout rather than to >> format text, and other things that could be improved. >> >> -- Gary >> >> >> On 08/07/2012 06:14, luciash wrote: >>> Hi, >>> >>> if I am not mistaken, Gary meant that <br class="clear" /> is redundant, >>> because we have clearfix class for the element after which it should be >>> cleared (it creates br using pseudo-element :after anyway iirc) to deal >>> with that and that any <br /> (or <br> - it does not matter in HTML5, >>> both are valid) cause unwanted extra white space (line break). >>> >>> I do not see the issue was <br /> vs <br> here. >>> >>> It is more issue (if any) for template designers: "do not use <br>|<br >>> /> unless you really need to" -- for layout stuff from semantic point of >>> view (same applies for ). >>> >>> luci >>> >>> >>> >>> On 7.7.2012 13:59, Jonny Bradley wrote: >>>> On 7 Jul 2012, at 11:26, Gary Cunningham-Lee wrote: >>>> >>>>> Done in r42250. >>>>> >>>>> -- Gary >>>>> >>>> Thanks Chibaguy! :) Replying on dev list for discussion... >>>> >>>> On the <br> vs <br /> issue, shall we do a mass search and replace for Tiki 10 __after__ the automerge period is over? Should shave a few KB off? (and obviously any new edited or ones meanwhile we can lose the self-close) >>>> >>>> All those in favour +1? >>>> >>>> Any any other left-over html5 issue to address then? >>>> >>>> jb >>>> >>>> >>>> >>>>> On 07/07/2012 08:38, Jonny Bradley wrote: >>>>>> Sounds good - not also the case in 9.x? ;) >>>>>> >>>>>> jb >>>>>> >>>>>> On 6 Jul 2012, at 12:49, chi...@us... wrote: >>>>>> >>>>>>> Revision: 42242 >>>>>>> http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=42242&view=rev >>>>>>> Author: chibaguy >>>>>>> Date: 2012-07-06 11:49:22 +0000 (Fri, 06 Jul 2012) >>>>>>> Log Message: >>>>>>> ----------- >>>>>>> [FIX] Break tag causes unwanted white space and should be redundant when containing div has clearfix class. >>>>>>> >>>>>>> Modified Paths: >>>>>>> -------------- >>>>>>> trunk/templates/article_trailer.tpl >>>>>>> trunk/templates/comment-header.tpl >>>>>>> trunk/templates/tiki-stats.tpl >>>>>>> >>>>>>> Modified: trunk/templates/article_trailer.tpl >>>>>>> =================================================================== >>>>>>> --- trunk/templates/article_trailer.tpl 2012-07-05 21:29:18 UTC (rev 42241) >>>>>>> +++ trunk/templates/article_trailer.tpl 2012-07-06 11:49:22 UTC (rev 42242) >>>>>>> @@ -1,5 +1,5 @@ >>>>>>> {if !isset($preview)} >>>>>>> - <div class="articletrailer"> >>>>>>> + <div class="clearfix articletrailer"> >>>>>>> <span> >>>>>>> {if $show_size eq 'y'} >>>>>>> ({$size} {tr}bytes{/tr}) >>>>>>> @@ -42,5 +42,4 @@ >>>>>>> {/if} >>>>>>> </div> >>>>>>> </div> >>>>>>> - <br class="clear" /> >>>>>>> {/if} >>>>>>> \ No newline at end of file >>>>>>> >>>>>>> Modified: trunk/templates/comment-header.tpl >>>>>>> =================================================================== >>>>>>> --- trunk/templates/comment-header.tpl 2012-07-05 21:29:18 UTC (rev 42241) >>>>>>> +++ trunk/templates/comment-header.tpl 2012-07-06 11:49:22 UTC (rev 42242) >>>>>>> @@ -80,5 +80,4 @@ >>>>>>> {if $thread_style eq 'commentStyle_headers'} >>>>>>> {include file='comment-footer.tpl' comment=$comments_coms[rep]} >>>>>>> {/if} >>>>>>> - <br class="clear" /> >>>>>>> </div> >>>>>>> >>>>>>> Modified: trunk/templates/tiki-stats.tpl >>>>>>> =================================================================== >>>>>>> --- trunk/templates/tiki-stats.tpl 2012-07-05 21:29:18 UTC (rev 42241) >>>>>>> +++ trunk/templates/tiki-stats.tpl 2012-07-06 11:49:22 UTC (rev 42242) >>>>>>> @@ -2,7 +2,7 @@ >>>>>>> >>>>>>> {title help="Stats"}{tr}Stats{/tr}{/title} >>>>>>> >>>>>>> -<div class="navbar"> >>>>>>> +<div class="clearfix navbar"> >>>>>>> {button _anchor="site_stats" _text="{tr}Site{/tr}"} >>>>>>> {if $wiki_stats}{button _anchor="wiki_stats" _text="{tr}Wiki{/tr}"}{/if} >>>>>>> {if $igal_stats}{button _anchor="igal_stats" _text="{tr}Image galleries{/tr}"}{/if} >>>>>>> @@ -19,8 +19,6 @@ >>>>>>> {if $best_objects_stats_lastweek}{button _anchor="best_objects_stats_lastweek" _text="{tr}Most viewed objects in the last 7 days{/tr}"}{/if} >>>>>>> </div> >>>>>>> >>>>>>> -<br class="clear" /> >>>>>>> - >>>>>>> <h2 id="site_stats">{tr}Site Stats{/tr}</h2> >>>>>>> {cycle values="odd,even" print=false advance=false} >>>>>>> <table class="formcolor"> >>>>>>> >>>>>>> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. >>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------------------------ >>>>>>> Live Security Virtual Conference >>>>>>> Exclusive live event will cover all the ways today's security and >>>>>>> threat landscape has changed and how IT managers can respond. Discussions >>>>>>> will include endpoint security, mobile security and the latest in malware >>>>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>>>>>> _______________________________________________ >>>>>>> Tikiwiki-cvs mailing list >>>>>>> Tik...@li... >>>>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >>>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Live Security Virtual Conference >>>>>> Exclusive live event will cover all the ways today's security and >>>>>> threat landscape has changed and how IT managers can respond. Discussions >>>>>> will include endpoint security, mobile security and the latest in malware >>>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>>>>> _______________________________________________ >>>>>> Tikiwiki-cvs mailing list >>>>>> Tik...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >>>>>> >>>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Live Security Virtual Conference >>>>> Exclusive live event will cover all the ways today's security and >>>>> threat landscape has changed and how IT managers can respond. Discussions >>>>> will include endpoint security, mobile security and the latest in malware >>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>>>> _______________________________________________ >>>>> Tikiwiki-cvs mailing list >>>>> Tik...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >>>>> >>>> ------------------------------------------------------------------------------ >>>> Live Security Virtual Conference >>>> Exclusive live event will cover all the ways today's security and >>>> threat landscape has changed and how IT managers can respond. Discussions >>>> will include endpoint security, mobile security and the latest in malware >>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>>> _______________________________________________ >>>> TikiWiki-devel mailing list >>>> Tik...@li... >>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel >>> ------------------------------------------------------------------------------ >>> Live Security Virtual Conference >>> Exclusive live event will cover all the ways today's security and >>> threat landscape has changed and how IT managers can respond. Discussions >>> will include endpoint security, mobile security and the latest in malware >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>> _______________________________________________ >>> TikiWiki-devel mailing list >>> Tik...@li... >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel >>> >>> >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> TikiWiki-devel mailing list >> Tik...@li... >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > TikiWiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > > |