From: Gary Cunningham-L. <ga...@cu...> - 2012-06-02 13:12:19
|
Hi, I've got some questions about the Double Dot Media Ltd theme that was committed (r41645). I asked on the CVS list but didn't get a reply. First, I don't think it's a good idea to use the company name in the theme name and file paths, etc., or to include the company logo as a file for distribution. I suggest that instances of "Double Dot" be changed to something generic, and that the company logo files be removed. Credit for their contribution of the theme should probably be limited to the file comments. Second, I wonder if it'd be possible to see a screenshot of the theme as it is meant to look. In my trunk installation at least, it seems to be broken to some extent: the right column isn't behaving in the normal Tiki fashion (absolutely positioned to the right so that it's often either too far separated from the other content or is overlapping it, depending on the screen and content widths), and the topbar menu looks and acts kind of strange (apparent mix of visual styles, and overlapping menu items, oddly changing text weight and so on). Maybe the theme expects a certain configuration of modules, etc. that should be documented. I suggest maybe cleaning it up and moving it to be an option under jqui, since it appears to be based on jqui to a large extent, and also maybe removing its theme options as they seem to be only slightly changed variants of the same options under jqui (again unless I'm missing something with my trunk configuration). Any opinions on this? -- Gary |