[Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[40925] branches/9.x

[<li...@us...>]

Revision: 40925
          http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=40925&view=rev
Author:   lindonb
Date:     2012-04-15 17:42:29 +0000 (Sun, 15 Apr 2012)
Log Message:
-----------
[FIX] Renumber array keys from 0 for article topic arrays used in Smarty section loops. It appears there may be a bug in Smarty 3 in looping through arrays that aren't zero-based. I don't see a bug report but it is noted here: https://bugs.launchpad.net/phpdevshell/+bug/781565

Modified Paths:
--------------
    branches/9.x/modules/mod-func-article_topics.php
    branches/9.x/tiki-admin_topics.php
    branches/9.x/tiki-edit_article.php

Modified: branches/9.x/modules/mod-func-article_topics.php
===================================================================
--- branches/9.x/modules/mod-func-article_topics.php	2012-04-15 15:31:56 UTC (rev 40924)
+++ branches/9.x/modules/mod-func-article_topics.php	2012-04-15 17:42:29 UTC (rev 40925)
@@ -28,5 +28,9 @@
 	global $artlib; include_once('lib/articles/artlib.php');
 	
 	$listTopics = $artlib->list_topics();
+	/* To renumber array keys from 0 since smarty 3 doesn't seem to like arrays
+	 * that start with other keys in a section loop, which this variable is used in
+	 */
+	$listTopics = array_values($listTopics);
 	$smarty->assign('listTopics', $listTopics);
 }

Modified: branches/9.x/tiki-admin_topics.php
===================================================================
--- branches/9.x/tiki-admin_topics.php	2012-04-15 15:31:56 UTC (rev 40924)
+++ branches/9.x/tiki-admin_topics.php	2012-04-15 17:42:29 UTC (rev 40925)
@@ -47,6 +47,10 @@
 	$artlib->deactivate_topic($_REQUEST["deactivate"]);
 }
 $topics = $artlib->list_topics();
+/* To renumber array keys from 0 since smarty 3 doesn't seem to like arrays
+ * that start with other keys in a section loop, which this variable is used in
+ */
+$topics = array_values($topics);
 $temp_max = count($topics);
 for ($i = 0; $i < $temp_max; $i++) {
 	if ($userlib->object_has_one_permission($topics[$i]["topicId"], 'topic')) {

Modified: branches/9.x/tiki-edit_article.php
===================================================================
--- branches/9.x/tiki-edit_article.php	2012-04-15 15:31:56 UTC (rev 40924)
+++ branches/9.x/tiki-edit_article.php	2012-04-15 17:42:29 UTC (rev 40925)
@@ -224,6 +224,10 @@
 }
 
 $topics = $artlib->list_topics();
+/* To renumber array keys from 0 since smarty 3 doesn't seem to like arrays
+ * that start with other keys in a section loop, which this variable is used in
+ */
+$topics = array_values($topics);
 $smarty->assign_by_ref('topics', $topics);
 
 if (isset($_REQUEST['preview']))

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.