From: Jonny B. <jo...@ti...> - 2011-08-12 13:14:39
|
On 12 Aug 2011, at 14:05, Sylvie Greverend wrote: > Comment in a snippet > On Thu, 2011-08-11 at 23:11 +0000, se...@us... wrote: >> Revision: 36096 >> http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=36096&view=rev >> Author: sept_7 >> Date: 2011-08-11 23:11:30 +0000 (Thu, 11 Aug 2011) >> >> Log Message: >> ----------- >> [FIX] Notices both in PHP and Smarty >> > >> Modified: trunk/templates/modules/mod-logo.tpl >> =================================================================== >> --- trunk/templates/modules/mod-logo.tpl 2011-08-11 23:07:02 UTC (rev 36095) >> +++ trunk/templates/modules/mod-logo.tpl 2011-08-11 23:11:30 UTC (rev 36096) >> @@ -7,9 +7,8 @@ >> </div> >> <div id="sitetitles" class="floatleft"> >> <div id="sitetitle"> >> - <a href="./"{if isset($prefs.mobile_mode) && $prefs.mobile_mode eq "y"} rel="external"{/if}>{$prefs.sitetitle}</a> >> + <a href="./"{if isset($prefs.mobile_mode) && $prefs.mobile_mode eq "y"} rel="external"{/if}>{if !empty($prefs.sitetitle)}{$prefs.sitetitle}{/if}</a> >> </div> >> - <div id="sitesubtitle">{$prefs.sitesubtitle} >> - </div> >> + <div id="sitesubtitle">{if !empty($prefs.sitesubtitle)}{$prefs.sitesubtitle}{/if}</div> > I thought hat all the prefs had a default value and did not need to be > tested? Was working like that for some time. Is it broken? Hi Sylvie Yes, you're right generally - but mobile_mode is a dynamic one set up by lib/setup/mobile.php if mobile_feature is on and it's rendering in mobile mode, so isn't set at all if mobile_feature is off (i think). Not sure why $prefs.sitetitle was generating a notice sometimes though... jb |