From: Marc L. <ma...@ma...> - 2010-12-05 23:46:18
|
profiles.tiki.org is not showing base with latest 6.x I turned it off on all sites except profiles to show the issue. Thanks! M ;-) On Sun, Dec 5, 2010 at 4:56 PM, Marc Laporte <ma...@ma...> wrote: > ok, I reinstated on *.tiki.org sites So it will be fixed in a few > hours when the site is updated to latest 6.x > > > Nyloth added this November 5th, 2007 with the comment: > > [MOD] base tag in html: add the base tag only if we are not at the > root (i.e. only if dir_level > 0) > http://tikiwiki.cvs.sourceforge.net/viewvc/tikiwiki/tiki/templates/header.tpl?r1=1.86.2.5&r2=1.86.2.6&pathrev=BRANCH-1-10 > > > If a site is not at the root, isn't it also important to have a base? > > Nyloth? Anyone? > > > Thanks! > > M ;-) > > > On Sun, Dec 5, 2010 at 2:36 PM, Jonny Bradley <jo...@ti...> wrote: >> >> On 5 Dec 2010, at 00:04, Marc Laporte wrote: >> >>> Hi! >>> >>> What do you mean by nested directories? >> >> I actually have no idea but the code in header.tpl originally said: >> >> {if $base_url and $dir_level gt 0} >> >> The <base> tag seems quite necessary to me (some sites more than others) but the rules say "make it optional", hence another pref is born ;) >> >> One day i'd like to revamp the sefurls we use so they're actually valid (no &'s in them without a ? first) and like normal urls e.g. "/page/Page+Name/structure/42/highlight/search+term" or "/blog/A+Blog/post/94/Name+of+the+post" - the <base> tag will be necessary for that too. >> >>> I activated on dev.t.o and I see this in source: >>> <base href="http://dev.tiki.org/" /> >> >> and then On 5 Dec 2010, at 08:02, Marc Laporte wrote: >> >>> I turned it off because it causes problems with {maketoc} >>> >>> Jonny? >> >> Hmm, so it does... looks like the spec for <base> (http://www.w3.org/TR/html4/struct/links.html#h-12.4) says it should be the whole URL, including the page or script name, depending on sefurl etc... >> >> Ok, fixed in r31147 hopefully if you're in that area again... ;) >> >> jb >> >> >> >> >>> >>> On Sat, Nov 20, 2010 at 7:38 AM, <jon...@us...> wrote: >>>> Revision: 30807 >>>> http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=30807&view=rev >>>> Author: jonnybradley >>>> Date: 2010-11-20 12:38:58 +0000 (Sat, 20 Nov 2010) >>>> >>>> Log Message: >>>> ----------- >>>> [ENH] html: Pref to control the use of the <base> tag in the page<head> (currently only used when in nested directories) >>>> >>>> Modified Paths: >>>> -------------- >>>> branches/6.x/lib/prefs/feature.php >>>> branches/6.x/lib/setup/prefs.php >>>> branches/6.x/templates/header.tpl >>>> branches/6.x/templates/tiki-admin_include_look.tpl >>>> >>>> Modified: branches/6.x/lib/prefs/feature.php >>>> =================================================================== >>>> --- branches/6.x/lib/prefs/feature.php 2010-11-20 11:26:05 UTC (rev 30806) >>>> +++ branches/6.x/lib/prefs/feature.php 2010-11-20 12:38:58 UTC (rev 30807) >>>> @@ -1121,6 +1121,11 @@ >>>> 'size' => '6', >>>> 'filter' => 'rawhtml_unsafe', >>>> ), >>>> + 'feature_html_head_base_tag' => array( >>>> + 'name' => tra('Add BASE tag in the page HEAD'), >>>> + 'type' => 'flag', >>>> + 'description' => tra('The <base> tag specifies a default address for all links on a page.'), >>>> + ), >>>> 'feature_sitemycode' => array( >>>> 'name' => tra('Custom Site Header'), >>>> 'type' => 'flag', >>>> >>>> Modified: branches/6.x/lib/setup/prefs.php >>>> =================================================================== >>>> --- branches/6.x/lib/setup/prefs.php 2010-11-20 11:26:05 UTC (rev 30806) >>>> +++ branches/6.x/lib/setup/prefs.php 2010-11-20 12:38:58 UTC (rev 30807) >>>> @@ -1311,6 +1311,7 @@ >>>> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">', >>>> 'feature_custom_html_head_content' => '{if $prefs.feature_secondary_sitemenu_custom_code ne ""}<style type="text/css">#sitelogo img {literal}{margin-top: 0; position: relative; top: -12px;}{/literal}</style>{/if}', >>>> 'feature_fixed_width' => 'y', >>>> + 'feature_html_head_base_tag' => 'n', >>>> >>>> // layout >>>> 'feature_left_column' => 'y', >>>> >>>> Modified: branches/6.x/templates/header.tpl >>>> =================================================================== >>>> --- branches/6.x/templates/header.tpl 2010-11-20 11:26:05 UTC (rev 30806) >>>> +++ branches/6.x/templates/header.tpl 2010-11-20 12:38:58 UTC (rev 30807) >>>> @@ -1,5 +1,5 @@ >>>> {* $Id$ *} >>>> -{if $base_url and $dir_level gt 0} >>>> +{if $base_url and ($dir_level gt 0 or $prefs.feature_html_head_base_tag eq 'y')} >>>> <base href="{$base_url|escape}" /> >>>> {/if} >>>> <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> >>>> >>>> Modified: branches/6.x/templates/tiki-admin_include_look.tpl >>>> =================================================================== >>>> --- branches/6.x/templates/tiki-admin_include_look.tpl 2010-11-20 11:26:05 UTC (rev 30806) >>>> +++ branches/6.x/templates/tiki-admin_include_look.tpl 2010-11-20 12:38:58 UTC (rev 30807) >>>> @@ -85,6 +85,7 @@ >>>> <div class="adminoptionboxchild" id="feature_custom_doctype_childcontainer"> >>>> {preference name=feature_custom_doctype_content} >>>> </div> >>>> + {preference name=feature_html_head_base_tag} >>>> {preference name=feature_custom_html_head_content} >>>> {preference name=feature_secondary_sitemenu_custom_code} >>>> {preference name=feature_sitemycode} >>>> >>>> >>>> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. >>>> >>>> ------------------------------------------------------------------------------ >>>> Beautiful is writing same markup. Internet Explorer 9 supports >>>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >>>> Spend less time writing and rewriting code and more time creating great >>>> experiences on the web. Be a part of the beta today >>>> http://p.sf.net/sfu/msIE9-sfdev2dev >>>> _______________________________________________ >>>> Tikiwiki-cvs mailing list >>>> Tik...@li... >>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >>>> >>> >>> >>> >>> -- >>> Marc Laporte >>> >>> http://MarcLaporte.com >>> http://Tiki.org/MarcLaporte >>> http://AvanTech.net >>> >>> ------------------------------------------------------------------------------ >>> What happens now with your Lotus Notes apps - do you make another costly >>> upgrade, or settle for being marooned without product support? Time to move >>> off Lotus Notes and onto the cloud with Force.com, apps are easier to build, >>> use, and manage than apps on traditional platforms. Sign up for the Lotus >>> Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d >>> _______________________________________________ >>> Tikiwiki-cvs mailing list >>> Tik...@li... >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >> >> >> ------------------------------------------------------------------------------ >> What happens now with your Lotus Notes apps - do you make another costly >> upgrade, or settle for being marooned without product support? Time to move >> off Lotus Notes and onto the cloud with Force.com, apps are easier to build, >> use, and manage than apps on traditional platforms. Sign up for the Lotus >> Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d >> _______________________________________________ >> Tikiwiki-cvs mailing list >> Tik...@li... >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >> > > > > -- > Marc Laporte > > http://MarcLaporte.com > http://Tiki.org/MarcLaporte > http://AvanTech.net > -- Marc Laporte http://MarcLaporte.com http://Tiki.org/MarcLaporte http://AvanTech.net |