[Tiki-devel] HTML in menu option names (was Re: [Tikiwiki-devel] tiki 6 regression: icons in menu options)

[Filipus K. <ch...@gm...>]

On 2010-11-13 16:26, Rick Sapir wrote:
> Prior to TIki 6, it was possible to add an icon to any menu option, 
> simply by adding <img src="......" /> in the NAME field when adding a 
> menu option.
> In Tiki 6, this seems to be broken -- sometimes. You can see this on 
> http://info.tiki.org
> - The icon for the Getting Started menu option appears, as expected.
> - The icon for the Features > Promo Sheet menu option does *not* 
> render. Instead you see the HTML coding.
> Anyone know what's up or how to correct?
Hi Rick,
first, here is what happened if I'm not missing something. In r22292, I 
escaped menu option names in the administration page and in the classic 
menu (thanks Sylvie for digging that). This released in Tiki 4. In 
r30646, I escaped them in CSS menus too. This didn't release yet 
(committed November 11th on branch 6.x). In r30773 eromneg reverted all 
of this (r30646 plus the relevant part of r22292) in branch 6.x.

Things were a bit different on info, where you noticed the image 
problem. Jean-François reverted part of r30646 locally to fix the 
top-level options. I fixed the leaf option removing the image. Later, 
eromneg reverted the remaining part of r30646, and even later I fixed 
the top-level option.

BTW, I notice I seem to have missed some places in tiki-user_menu.tpl in 
r22292, so maybe that's why there was no noise about the change before.

As for how to correct, this is a more complicated question. I see Gary 
says he's using the HTML in name trick, and we were using it ourselves 
on info. How many people/sites are using this trick?