From: Stephane C. <se...@lo...> - 2010-10-19 23:21:35
|
Le Tue, Oct 19, 2010 at 06:06:24PM +0100, Jonny Bradley écrivait : > > On 19 Oct 2010, at 16:07, Stephane Casset wrote: > > > Le Tue, Oct 19, 2010 at 02:03:27PM +0000, jon...@us... écrivait : > >> Revision: 30122 > >> http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=30122&view=rev > >> Author: jonnybradley > >> Date: 2010-10-19 14:03:27 +0000 (Tue, 19 Oct 2010) > >> > >> Log Message: > >> ----------- > >> [FIX] sheets: Make new JS libs external (too buggy to be minified) > >> > >> Modified Paths: > >> -------------- > >> branches/6.x/tiki-setup.php > >> > >> Modified: branches/6.x/tiki-setup.php > >> =================================================================== > >> --- branches/6.x/tiki-setup.php 2010-10-19 13:59:33 UTC (rev 30121) > >> +++ branches/6.x/tiki-setup.php 2010-10-19 14:03:27 UTC (rev 30122) > >> @@ -275,12 +275,12 @@ > >> $headerlib->add_cssfile( 'lib/jquery/jquery.sheet/plugins/menu.css' ); > >> $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/mbMenu.min.js' ); > >> $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/jquery.scrollTo-min.js' ); > >> - $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/raphael-min.js' ); > >> - $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/g.raphael-min.js' ); > >> - $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/g.pie-min.js' ); > >> - $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/g.line-min.js' ); > >> - $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/g.dot-min.js' ); > >> - $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/g.bar-min.js' ); > >> + $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/raphael-min.js', 'external' ); > >> + $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/g.raphael-min.js', 'external' ); > >> + $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/g.pie-min.js', 'external' ); > >> + $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/g.line-min.js', 'external' ); > >> + $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/g.dot-min.js', 'external' ); > >> + $headerlib->add_jsfile( 'lib/jquery/jquery.sheet/plugins/g.bar-min.js', 'external' ); > > > > You can change thes line to $headerlib->add_jsfile( path, 0, true); to > > skip minification but still include these file in the big JS file > > generated ans see if the pb is solved... Well they should normally be > > excluded since they end with min.js but... > > > > Really? Does it work for you? When i tried that for this fix it broke raphael when in non-minify mode. > > Please do go ahead and improve it if you can get it to work better than i ;) I will try to find time to investigate... A+ -- Stéphane Casset LOGIDÉE sàrl Se faire plaisir d'apprendre 1a, rue Pasteur Tel : +33 388 23 69 77 ca...@lo... F-67540 OSTWALD Fax : +33 388 23 69 77 http://logidee.com |