Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[21724] trunk/templates

[Sylvie G. <sgr...@gm...>]

I hate when I come on a bug - after a long discussion on the list
In the blog the comment buttom is broken And the rollback fixes it
Goto tiki-view_blog.php
Click on comments taht is close to Permalink
Depending on the cookie_jar configuration
you arrive on an empty screen
or if it is correct
hide the comment and go again to tiki-view_blog

For me if show_comments or show_comzone is on - the comments must appear

So sorry luciash can you explain the commit
Thx
sylvie

On Thu, 2009-09-24 at 23:54 +0200, Stephane Casset wrote:
> Le Thu, Sep 24, 2009 at 09:33:42PM +0200, luci aka luciash d' being écrivait :
> > salut,
> > 
> > On 09/24/2009 02:50 PM, Stephane Casset wrote:
> > > Le Thu, Sep 24, 2009 at 01:42:52PM +0200, luci aka luciash d' being écrivait :
> > >   
> > >> no,
> > >>
> > >> it doesn't work
> > >> comzone=hide is not an html attribute but URL variable
> > >>     
> > >
> > > Yes {button var1=val1 ....}
> > > var1 is set to val1 if var1 is in the auto_query_args of the PHP script.
> > >   
> > 
> > ah, didn't know that, thanks for the hint !
> 
> You are welcome ! ;p
> 
> > > Luci if it is the only parameter then you can do :
> > >
> > > {button comzone='hide' _anchor='comments' _auto_args="comzone"
> > > _class=$thisbuttonclass _text=$thistext _flip_default_open=$flip_open}
> > >
> > > Or add the necessary parameters in auto_args... I think we can do
> > > something like :
> > >   auto_args='*' -> add auto_query_args
> > >   auto_args='+var1,var2' -> add var1, var2 to auto_query_args
> > >   auto_args='var1,var2'  -> override auto_query_args with only var1,var2
> > >
> > > Or maybe even better :
> > >   auto_args="+var1,-var2" -> add var1 to auto_query_args and remove var2
> > > from the query arguments ?
> > >
> > > What do you think ?
> > >
> > >   
> > 
> > i don't know what is the best... i added it as _auto_args="comzone,*"
> > and it seems to work ?
> 
> Well as the code is now it means that only comzone is valid as a query
> argument... so if you need more arguments from auto_query_args it will
> fail... But we could enhance {button} if needed ! ;p
> 
> A+