Re: [Tikiwiki-devel] shouldn't all '{tr} .... {/tr}' be "{tr} .... {/tr}"?

[Xavier de P. <xav...@ub...>]

Got no more comments about this in the last month, so I've just  
committed it to trunk: r28804
Hope everything is fine (and/or better for languages using single quotes 
in the l10n strings).
Xavi

Al 29/07/10 14:49, En/na Xavier de Pedro ha escrit:
> Hi all:
>
> I bring back this issue since it's related to my recent message at the
> thread about 5.1 release process.
>
> I volunteer to do the change semi-automàtic (revised one by one by a
> human with the help of replace in multiple files, etc.) from '{tr} ....
> {/tr}' to "{tr} .... {/tr}" in 5.x before 5.1 is release (right now
> 5.xsvn is broken for Catalan community again, due to this bug): help box
> and plugin helper, etc. don't even show up in the page when you click at
> the help button in the edit wiki page interface...
>
> I could change the string who produces that to remove the single quote,
> but for sure this issue will come back later on in other areas (if not
> happening already in other areas), so I would suggest that we fix it
> properly in our tpl's.
>
> Xavi
>
> Al 05/06/10 01:36, En/na Filipus Klutiero ha escrit:
>    
>> I don't think " is intrinsically better than the single quote. It may be
>> better to use it in general - statistically - if there are less double
>> quotes than single quotes in translations. Given this and the risk of
>> breakage, I tend to agree with Jonny that this shouldn't be done in batch.
>>
>> If it is done, I definitely agree it should not be done in 5.x.
>>
>> On 2010-06-03 08:57, Sylvie Greverend wrote:
>>
>>      
>>> We need to do a batch to change all the '{tr}...{/tr}' to "{tr}...{/tr}"
>>> I began but did not have time to finish .. because better to check
>>> automatic replacement
>>> Any volunteer?
>>> Thx
>>>
>>> On Thu, 2010-06-03 at 10:02 +0200, Xavier de Pedro wrote:
>>>
>>>
>>>        
>>>> Hi all:
>>>>
>>>> In a production site where I'm using 4.2 with some of my students, I
>>>> made some small update to the Catalan language file, and then, the
>>>> toolbar icon to switch from wysiwyg to normal editor stopped working
>>>> (clicking on the  icon did nothing). Interface language was Catalan.
>>>> When I switched to English, the button worked as expected again.
>>>>
>>>> The diff of that change in language.php can be seen here:
>>>> http://tikiwiki.svn.sourceforge.net/viewvc/tikiwiki/branches/4.x/lang/ca/language.php?r1=25955&r2=27426
>>>>
>>>> Some of the potentially "dangerous" (?) changes seem to be like this:
>>>>
>>>> 4132
>>>>     // "Switch Editor
>>>> (wiki or WYSIWYG)" =>
>>>> "Switch Editor (wiki or
>>>> WYSIWYG)",
>>>>     "Switch Editor (wiki
>>>> or WYSIWYG)" =>    "Canvia
>>>> d'Editor (wiki o
>>>> WYSIWYG)",
>>>>
>>>>
>>>> So, adding a few strings with single quotes inside the translation,
>>>> and removing one from a wrong translation.
>>>>
>>>> After some discussion in irc about it
>>>> ( http://irc.tikiwiki.org/irclogger_log/tikiwiki?date=2010-06-02,Wed&sel=647#l643  ) , and doing some attempts to fix (sorry for the useless commit to proposals/4.x/lib/toolbars/toolbarslib.php , I would revert myself if I could), it seems that the problem might be related to using single quotes in the code to surround {tr} tags:
>>>>
>>>>     '{tr} .... {/tr}'
>>>>
>>>> And it seems (If I undertood correctly), that they shoould be:
>>>>
>>>> "{tr} .... {/tr}"
>>>>
>>>> Well, I searched for:
>>>>
>>>> '{tr}
>>>>
>>>> in trunk and there many many matches (so that also in 5.x&    also in
>>>> 4.x)...
>>>>
>>>> What shall we do with it?
>>>> What's the best solution for the recurrent problem with languages
>>>> where we use single quotes in the translated strings?
>>>>
>>>> (as Sylvie, I don't think that it should be translators who escape
>>>> single quotes in the language.php )
>>>>
>>>> HTH
>>>>
>>>> Xavi
>>>>
>>>>
>>>>          
>> ------------------------------------------------------------------------------
>> ThinkGeek and WIRED's GeekDad team up for the Ultimate
>> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
>> lucky parental unit.  See the prize list and enter to win:
>> http://p.sf.net/sfu/thinkgeek-promo
>> _______________________________________________
>> Tikiwiki-devel mailing list
>> Tik...@li...
>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>>
>>
>>      
>
> ------------------------------------------------------------------------------
> The Palm PDK Hot Apps Program offers developers who use the
> Plug-In Development Kit to bring their C/C++ apps to Palm for a share
> of $1 Million in cash or HP Products. Visit us here for more details:
> http://p.sf.net/sfu/dev2dev-palm
> _______________________________________________
> Tikiwiki-devel mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
>