From: Marc L. <ma...@ma...> - 2010-07-16 20:28:29
|
Hi! That is a great idea in trunk. But 5.x is not the place to experiment and develop things like this. We made a mistake to accept this commit after Tiki5RC2 and i apologize for that. Now, we restore to what is well tested in 4.3 Once something works and is tested in trunk, it can be sent to the quality team for 5.2. M ;-) On Fri, Jul 16, 2010 at 10:09 PM, luci aka luciash d' being <sf...@gr...> wrote: > hmm, > > this is no good to release like this asap (imho) ... > > wouldn't it be better to add a little database test step in the > installer and depending on the results let the admin decide to add the > charset string in db/local.php or not (or comment out) ? > > luci > > > On 07/16/2010 09:16 PM, Marc Laporte wrote: >> Hi! >> >> So in conclusion, this change has introduced some issues in some contexts: >> http://tikiwiki.org/ReleaseNotes5.0#Database_Encoding_Issues >> >> And directly or indirectly: >> http://tikiwiki.org/ReleaseNotes5.0#Corrupted_file_uploads >> >> There comes a point where a decision must be made to continue along >> and make it work, or to backtrack. Over a month after the 5.0 release, >> there are still many things that are not clear. Because of the >> uncertainty, and lack of people to work on this and test, and because >> of severe consequences for some, we will roll it back tomorrow and >> release 5.1 ASAP. >> >> There are too many people whose site will be upgraded via Fantastico >> or other admin panels and having manual steps will just cause too many >> support requests. >> >> So we'll go back to the way it was in 4.3 The consequence is that some >> people that installed or upgraded to 5.0 will have some manual >> corrections to make to their data. This is not cool and I apologize >> for this. However, it's a lesser problem than having everyone upgrade. >> >> I hope we can try to fix this for Tiki6. There also needs to be a data >> migration script. LP committed one a few days ago during the TikiFest >> but it is not sufficiently tested. >> >> Best regards, >> >> M ;-) >> >> >> On Tue, Jun 1, 2010 at 12:56 AM, Marc Laporte <ma...@ma...> wrote: >> >>> Great idea xavi! (It's similar to what we do for .htaccess) >>> >>> Thank you Nyloth! I'll be testing now!! >>> >>> M ;-) >>> >>> On Mon, May 31, 2010 at 2:54 PM, Xavier de Pedro <xav...@ub...> wrote: >>> >>>> Thanks Nyloth! >>>> >>>> One small suggestion: >>>> >>>>> 3- Can (should this be optional) in case it causes issues? >>>>> => we can just put in the release notes that users can change >>>>> $client_charset in db/local.php to whatever they want >>>>> >>>> Can you put that also inside the db/local.php file as some commented line? >>>> And also something similar to easily change from PDO to AdoDB >>>> (uncommenting some line), with some indications for users, as commented >>>> lines, such as: >>>> >>>> // If you are experiencing error messages about missing PDO in the >>>> server, uncomment the following line to switch back to AdoDB instead: >>>> //"whatever line to switch from PDO to AdoDB" >>>> >>>> // If you are experiencing charset problems or your attachments got >>>> corrupted or ..., uncomment the following line to use this other charset >>>> instead (xxx). See http://doc.tikiwiki.org/UTF-8 [or whatever url with >>>> more information]: >>>> //"whatever line to switch to another charset" >>>> >>>> Or something similar. This might make things much easier for users with >>>> those problems when they upgrade, etc. >>>> >>>> My 2 cents. >>>> >>>> Xavi >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> >>>> _______________________________________________ >>>> Tikiwiki-devel mailing list >>>> Tik...@li... >>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel >>>> >>>> >>> >>> >>> -- >>> Marc Laporte >>> >>> http://MarcLaporte.com >>> http://TikiWiki.org/MarcLaporte >>> http://AvanTech.net >>> http://OurWiki.net >>> >>> >> >> >> > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Sprint > What will you do first with EVO, the first 4G phone? > Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first > _______________________________________________ > Tikiwiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > -- Marc Laporte http://MarcLaporte.com http://TikiWiki.org/MarcLaporte http://AvanTech.net http://OurWiki.net |