Menu
▾
▴
Re: [Tikiwiki-devel] [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[26544] branches/5.x/installer/schema/ 20100409_bigger_module_params_tiki.sql
|
From: Jonny B. <jo...@ti...> - 2010-04-13 11:01:40
|
Hmm, so it's a MySQL 4 thing... i don't have shell access or anything useful to a mysql 4 server now... so hard to test, but... It just occurred to me why is the `param` column part of the PRIMARY KEY - seems a bit mad, no? Shall i just remove it if it's causing this error? Cc'ing devels for wider comments jb On 12 Apr 2010, at 20:18, Marc Laporte wrote: > With latest branches/5.x , an upgrade from 4.x with PHP version > 5.2.9 and MySQL version 4.1.22-standard > > > At revision 26596. > [etmisqc@alpha www]$ php installer/shell.php > Running installer for: db/local.php > Patches installed: > 20060116_showlastDownLoad_tiki > 20090226_admin_menu_tiki > 20091105_auth_tokens_tiki > 20091112_template_type_tiki > 20091118_sefurl_tiki > 20091120_poll_lookup_index_tiki > 20091123_dns_permission_tiki > 20091123_metrics_tiki > 20091124_fgal_backlink_tiki > 20091124_metrics_dsn_tiki > 20091126_dynamic_variables_i18n_tiki > 20091204_tiki_p_view_newsletter_tiki > 20091208_backlink_perms_tiki > 20091209_rss_feeds_name_tiki > 20091210_charset_tiki > 20091210_dcs_type_tiki > 20091214_perspective_management_tiki > 20091216_show_backlinks_tiki > 20091228_page_keywords_tiki > 20100101_search_modules_merge_tiki > 20100101_search_wiki_page_modules_merge_tiki > 20100104_tiki_p_tracker_revote_ratings_tiki > 20100106_forum_att_list_nb_tiki > 20100107_payment_tiki > 20100113_forum_display_tiki > 20100114_tiki_actionlog_merge_tiki > 20100115_admin_modules_menu_tiki > 20100115_main_menu_wiki_listpages_name_change_tiki > 20100115_tiki_p_admin_modules_tiki > 20100115_translations_in_progress_tiki > 20100117_old_doc_tw_o_url_tiki > 20100118_blog_use_author_tiki > 20100118_forum_display_tiki > 20100118_image_plugins_kill_tiki > 20100126_file_lastDownload_tiki > 20100128_tiki_p_blog_view_ref_tiki > 20100129_clean_up_tiki > 20100129_events_kil_tiki > 20100203_payment_detail_tiki > 20100205_tiki_p_wiki_view_ref_tiki > 20100211_rss_items_tiki > 20100211_tiki_perms_menu_item_tiki > 20100211_tiki_sheet_add_parseValues_tiki > 20100212_rss_automation_tiki > 20100213_group_inclusion_key_tiki > 20100214_workspaces_remove_menu_items_tiki > 20100215_create_tiki_user_login_cookies_tiki > 20100215_rating_permissions_tiki > 20100216_attributes_tiki > 20100216_kil_moz_screencast_tiki > 20100216_rename_tikisheet_tiki > 20100217_rating_config_tiki > 20100218_auth_token_reuse_tiki > 20100222_add_webmail_fromEmail_field_tiki > 20100222_sheet_toolbar_default_tiki > 20100223_blog_always_owner_tiki > 20100224_object_relations_tiki > 20100226_menu_template_feature_check_tiki > 20100302_filegal_images_max_sizes_tiki > 20100308_file_delete_after_tiki > 20100309_add_sheet_parent_tiki > Queries executed successfully: 5401 > Errors: > ===== Error 0 ===== > ALTER TABLE `tiki_modules` CHANGE `params` `params` TEXT > BLOB/TEXT column 'params' used in key specification without a key length > > > > > On Mon, Apr 12, 2010 at 7:36 AM, Jonny Bradley <jo...@ti...> wrote: >> >> Hi Marc >> >> That's odd - looking into it again i (re)discovered that you shouldn't define defaults for TEXT columns (r26585), and yes, keys must have a length specified, but for some reason yours doesn't have one? >> >> In tiki.sql i see on line 1495 PRIMARY KEY [...] `params`(140) >> >> Is that not what's in your database? Indeed strange, as even going back to Tiki 3 data, all my tiki_modules tables have this key length set. >> >> jb >> >> >> On 11 Apr 2010, at 13:58, Marc Laporte wrote: >> >>> After svn up, I got: >>> >>> [demotw@alpha 5x]$ php installer/shell.php >>> Running installer for: db/local.php >>> Queries executed successfully: 5174 >>> Errors: >>> ===== Error 0 ===== >>> ALTER TABLE `tiki_modules` CHANGE `params` `params` TEXT DEFAULT NULL >>> BLOB/TEXT column 'params' used in key specification without a key length >>> >>> >>> >>> >>> On Sat, Apr 10, 2010 at 6:18 AM, Jonny Bradley <jo...@ti...> wrote: >>>> >>>> Mea culpa - well spotted! >>>> >>>> Done in r26567 (also corrected the default - probably irrelevant, but would show up as an error if we had the release db structure check script! ;) >>>> >>>> jb >>>> >>>> On 10 Apr 2010, at 04:28, Marc Laporte wrote: >>>> >>>>> And in tiki.sql? >>>>> >>>>> It seems we were missing a step in our release procedure. I added here: >>>>> http://dev.tikiwiki.org/How+to+release#Check_database_structure >>>>> >>>>> Thanks! >>>>> >>>>> M ;-) >>>>> >>>>> >>>>> On Fri, Apr 9, 2010 at 8:35 AM, <jon...@us...> wrote: >>>>>> Revision: 26544 >>>>>> http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=26544&view=rev >>>>>> Author: jonnybradley >>>>>> Date: 2010-04-09 12:35:21 +0000 (Fri, 09 Apr 2010) >>>>>> >>>>>> Log Message: >>>>>> ----------- >>>>>> [FIX] Bigger field for module params (new search module default params ware getting truncated) >>>>>> >>>>>> Added Paths: >>>>>> ----------- >>>>>> branches/5.x/installer/schema/20100409_bigger_module_params_tiki.sql >>>>>> >>>>>> Added: branches/5.x/installer/schema/20100409_bigger_module_params_tiki.sql >>>>>> =================================================================== >>>>>> --- branches/5.x/installer/schema/20100409_bigger_module_params_tiki.sql (rev 0) >>>>>> +++ branches/5.x/installer/schema/20100409_bigger_module_params_tiki.sql 2010-04-09 12:35:21 UTC (rev 26544) >>>>>> @@ -0,0 +1 @@ >>>>>> +ALTER TABLE `tiki_modules` CHANGE `params` `params` TEXT NOT NULL DEFAULT ''; >>>>>> >>>>>> >>>>>> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Download Intel® Parallel Studio Eval >>>>>> Try the new software tools for yourself. Speed compiling, find bugs >>>>>> proactively, and fine-tune applications for parallel performance. >>>>>> See why Intel Parallel Studio got high marks during beta. >>>>>> http://p.sf.net/sfu/intel-sw-dev >>>>>> _______________________________________________ >>>>>> Tikiwiki-cvs mailing list >>>>>> Tik...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Marc Laporte >>>>> >>>>> http://MarcLaporte.com >>>>> http://TikiWiki.org/MarcLaporte >>>>> http://AvanTech.net >>>>> http://OurWiki.net >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Download Intel® Parallel Studio Eval >>>>> Try the new software tools for yourself. Speed compiling, find bugs >>>>> proactively, and fine-tune applications for parallel performance. >>>>> See why Intel Parallel Studio got high marks during beta. >>>>> http://p.sf.net/sfu/intel-sw-dev >>>>> _______________________________________________ >>>>> Tikiwiki-cvs mailing list >>>>> Tik...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Download Intel® Parallel Studio Eval >>>> Try the new software tools for yourself. Speed compiling, find bugs >>>> proactively, and fine-tune applications for parallel performance. >>>> See why Intel Parallel Studio got high marks during beta. >>>> http://p.sf.net/sfu/intel-sw-dev >>>> _______________________________________________ >>>> Tikiwiki-cvs mailing list >>>> Tik...@li... >>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >>>> >>> >>> >>> >>> -- >>> Marc Laporte >>> >>> http://MarcLaporte.com >>> http://TikiWiki.org/MarcLaporte >>> http://AvanTech.net >>> http://OurWiki.net >>> >>> ------------------------------------------------------------------------------ >>> Download Intel® Parallel Studio Eval >>> Try the new software tools for yourself. Speed compiling, find bugs >>> proactively, and fine-tune applications for parallel performance. >>> See why Intel Parallel Studio got high marks during beta. >>> http://p.sf.net/sfu/intel-sw-dev >>> _______________________________________________ >>> Tikiwiki-cvs mailing list >>> Tik...@li... >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >> >> >> ------------------------------------------------------------------------------ >> Download Intel® Parallel Studio Eval >> Try the new software tools for yourself. Speed compiling, find bugs >> proactively, and fine-tune applications for parallel performance. >> See why Intel Parallel Studio got high marks during beta. >> http://p.sf.net/sfu/intel-sw-dev >> _______________________________________________ >> Tikiwiki-cvs mailing list >> Tik...@li... >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >> > > > > -- > Marc Laporte > > http://MarcLaporte.com > http://TikiWiki.org/MarcLaporte > http://AvanTech.net > http://OurWiki.net > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Tikiwiki-cvs mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs |