Menu
▾
▴
Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[26140] branches/5.x
|
From: Gary Cunningham-L. <ga...@cu...> - 2010-03-16 15:50:55
|
On the admin side, probably there should be a checkbox to turn on the feature, then a textfield to input the width optionally. If nothing is input, then it defaults to 990px. This would be similar to how the site menu textarea and menu Id textfield work. Seems like if the figure is input, then a CSS rule would be added in head for document-level CSS. But I didn't know see how to combine this with the CSS file link in tiki-setup.php. If someone can describe how, I can finish it up. Also, as mentioned, it would be good to add a "fixed_width" class to the body tag when the feature is activated, but again I wasn't sure how to do this. -- Gary Marc Laporte wrote: > For now, in the CSS > > Perhaps you see a better way where 990 could be in admin panel? But > how to pass 990 to the CSS? > > Thanks! > > M ;-) > > > On Tue, Mar 16, 2010 at 8:46 AM, Jonny Bradley <jo...@ti...> wrote: > >> Hi Gary >> >> Well done, good implementation :) >> >> It seems to work, but how do you set the width? >> >> jb >> >> >> On 16 Mar 2010, at 12:28, chi...@us... wrote: >> >> >>> Revision: 26140 >>> http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=26140&view=rev >>> Author: chibaguy >>> Date: 2010-03-16 12:28:36 +0000 (Tue, 16 Mar 2010) >>> >>> Log Message: >>> ----------- >>> [ENH] Fixed-width option in Look and Feel Admin, so separate theme option files aren't needed. >>> >>> Modified Paths: >>> -------------- >>> branches/5.x/lib/prefs/feature.php >>> branches/5.x/lib/setup/prefs.php >>> branches/5.x/templates/tiki-admin-include-look.tpl >>> branches/5.x/tiki-setup.php >>> >>> Added Paths: >>> ----------- >>> branches/5.x/styles/layout/fixed_width.css >>> >>> Modified: branches/5.x/lib/prefs/feature.php >>> =================================================================== >>> --- branches/5.x/lib/prefs/feature.php 2010-03-16 12:23:33 UTC (rev 26139) >>> +++ branches/5.x/lib/prefs/feature.php 2010-03-16 12:28:36 UTC (rev 26140) >>> @@ -1684,5 +1684,10 @@ >>> 'name' => tra('WebDAV access to Tiki'), >>> 'type' => 'flag', >>> ), >>> + 'feature_fixed_width' => array( >>> + 'name' => tra('Fixed width'), >>> + 'type' => 'flag', >>> + 'description' => tra('Constrains the site display to 990px wide.'), >>> + ), >>> ); >>> } >>> >>> Modified: branches/5.x/lib/setup/prefs.php >>> =================================================================== >>> --- branches/5.x/lib/setup/prefs.php 2010-03-16 12:23:33 UTC (rev 26139) >>> +++ branches/5.x/lib/setup/prefs.php 2010-03-16 12:28:36 UTC (rev 26140) >>> @@ -1214,6 +1214,7 @@ >>> 'feature_endbody_code' => '', >>> 'feature_custom_html_head_content' => '', >>> 'users_prefs_theme' => '', >>> + 'feature_fixed_width' => 'y', >>> >>> // layout >>> 'feature_left_column' => 'y', >>> >>> Added: branches/5.x/styles/layout/fixed_width.css >>> =================================================================== >>> --- branches/5.x/styles/layout/fixed_width.css (rev 0) >>> +++ branches/5.x/styles/layout/fixed_width.css 2010-03-16 12:28:36 UTC (rev 26140) >>> @@ -0,0 +1,19 @@ >>> +/* $Id$ >>> + Fixed width option for any theme, TikiWiki CMS/Groupware. >>> +*/ >>> + >>> +#main[id] { >>> + margin-top: 18px; >>> + margin-bottom: 5px; >>> +} >>> + >>> +#fixedwidth { >>> + display: table; >>> + margin: auto; >>> + margin-top: 0; >>> + margin-bottom: 0px; >>> + width: 990px; >>> +} >>> +#fixedwidth[id] { >>> + height: auto; >>> +} >>> \ No newline at end of file >>> >>> >>> Property changes on: branches/5.x/styles/layout/fixed_width.css >>> ___________________________________________________________________ >>> Added: svn:keywords >>> + Id Date Author Revision >>> Added: svn:eol-style >>> + native >>> >>> Modified: branches/5.x/templates/tiki-admin-include-look.tpl >>> =================================================================== >>> --- branches/5.x/templates/tiki-admin-include-look.tpl 2010-03-16 12:23:33 UTC (rev 26139) >>> +++ branches/5.x/templates/tiki-admin-include-look.tpl 2010-03-16 12:28:36 UTC (rev 26140) >>> @@ -89,6 +89,7 @@ >>> >>> {tab name="{tr}General Layout options{/tr}"} >>> {preference name=feature_custom_html_head_content} >>> + {preference name=feature_fixed_width} >>> {preference name=feature_secondary_sitemenu_custom_code} >>> {preference name=feature_sitemycode} >>> <div class="adminoptionboxchild" id="feature_sitemycode_childcontainer"> >>> >>> Modified: branches/5.x/tiki-setup.php >>> =================================================================== >>> --- branches/5.x/tiki-setup.php 2010-03-16 12:23:33 UTC (rev 26139) >>> +++ branches/5.x/tiki-setup.php 2010-03-16 12:28:36 UTC (rev 26140) >>> @@ -145,6 +145,9 @@ >>> if( $prefs['feature_bidi'] == 'y' ) { >>> $headerlib->add_cssfile( 'styles/BiDi/BiDi.css' ); >>> } >>> +if( $prefs['feature_fixed_width'] == 'y' ) { >>> + $headerlib->add_cssfile( 'styles/layout/fixed_width.css' ); >>> +} >>> >>> if ($prefs['javascript_enabled'] == 'y') { >>> >>> >>> >>> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. >>> >>> ------------------------------------------------------------------------------ >>> Download Intel® Parallel Studio Eval >>> Try the new software tools for yourself. Speed compiling, find bugs >>> proactively, and fine-tune applications for parallel performance. >>> See why Intel Parallel Studio got high marks during beta. >>> http://p.sf.net/sfu/intel-sw-dev >>> _______________________________________________ >>> Tikiwiki-cvs mailing list >>> Tik...@li... >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >>> >> ------------------------------------------------------------------------------ >> Download Intel® Parallel Studio Eval >> Try the new software tools for yourself. Speed compiling, find bugs >> proactively, and fine-tune applications for parallel performance. >> See why Intel Parallel Studio got high marks during beta. >> http://p.sf.net/sfu/intel-sw-dev >> _______________________________________________ >> Tikiwiki-cvs mailing list >> Tik...@li... >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs >> >> > > > > > ------------------------------------------------------------------------ > > > No virus found in this incoming message. > Checked by AVG - www.avg.com > Version: 9.0.733 / Virus Database: 271.1.1/2749 - Release Date: 03/16/10 04:33:00 > > |