Menu
▾
▴
[Tikiwiki-devel] Questions about body CSS classes
|
From: Gary Cunningham-L. <ga...@cu...> - 2010-03-16 10:26:23
|
Hi, In branch 5x, the body tag (still - also true in 4.x and trunk) looks like <body class="tiki tiki_wiki_page">. Is there a reason for this redundancy? There was discussion several months ago but the problem wasn't resolved. I don't see a purpose for the "tiki" or "tiki_" class at all. What is its scope - every page Tiki serves? Since presumably the Tiki CSS files aren't used for pages other than in Tiki, the class is pointless, I think. The same purpose can be achieved by just applying a CSS rule globally. Then, about "wiki_page", I think having "wiki page" would be more useful, with one class for the section and one for the type of content. In fact, I believe this was the case earlier, but somehow the two classes mistakenly got combined into one. Currently even pages like tiki-listpages.php have the class "tiki_wiki_page" so they isn't distinguished from a wiki page proper, which seems wrong; tiki-listpages.php does also have a "manage" class, which makes sense, so "wiki manage" seems correct here - one class for the wiki section and the "manage" class for the function (to distinguish from wiki content pages). Also, I committed a tiki.tpl edit to give each wiki page an id in the body tag, based on pageId, so CSS could be page-specific. (I know lines of code can be added in Look & Feel to filter this, but I believe having the id added automatically would help keep L&F less cluttered, keep CSS more efficient, and so on.) I wonder what happened to that? Seems like it got lost when the body tag contents were moved out of the template. -- Gary |