Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[24765] trunk/lib/cache/cachelib.php

[Jonny B. <jo...@ti...>]

I *think* this and r24766 must be correct, but it implies that this getCached function is assumed to return a serialised result in some places, which it shouldn't... as far as i can tell. That should only be done by getSerialized().

Please watch out for more cache weirdness and PHP notices (this was causing an error on each userlink being displayed, and there were lots of them on page_history).

Hope this is right now...

jb

On 31 Jan 2010, at 15:23, jon...@us... wrote:

> Revision: 24765
>          http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=24765&view=rev
> Author:   jonnybradley
> Date:     2010-01-31 15:22:59 +0000 (Sun, 31 Jan 2010)
> 
> Log Message:
> -----------
> [FIX] CacheLibFileSystem::getCached() incorrectly returning serialized result (which will be done by getSerialized() if necessary)
> 
> Modified Paths:
> --------------
>    trunk/lib/cache/cachelib.php
> 
> Modified: trunk/lib/cache/cachelib.php
> ===================================================================
> --- trunk/lib/cache/cachelib.php	2010-01-31 15:18:55 UTC (rev 24764)
> +++ trunk/lib/cache/cachelib.php	2010-01-31 15:22:59 UTC (rev 24765)
> @@ -188,7 +188,7 @@
> 	function getCached($key, $type='') {
> 		$key = $type.md5($key);
> 		if ( !file_exists($this->folder."/$key")) { 	
> -			return serialize(false);
> +			return false;
> 		} 
> 		$fw = fopen($this->folder."/$key","r");
> 		if ($l = filesize($this->folder."/$key"))
> 
> 
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
> 
> ------------------------------------------------------------------------------
> The Planet: dedicated and managed hosting, cloud storage, colocation
> Stay online with enterprise data centers and the best network in the business
> Choose flexible plans and management services without long-term contracts
> Personal 24x7 support from experience hosting pros just a phone call away.
> http://p.sf.net/sfu/theplanet-com
> _______________________________________________
> Tikiwiki-cvs mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs