Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[21487] branches/proposed/installer/schema/ 20090913_plugin_security_addedby_tiki.sql

[Jonny B. <tw...@no...>]

+1 - but some thoughts follow...

Hmm - sorry to (also) be picky but wouldn't is be safer to add the  
field at the end of the table? In case there are any SELECT * FROM's  
going on? Especially in stable... maybe not a problem in this case but  
i've been bitten by that before (checked the code, seems ok).

I also agree it would be best to make it a rule not to have schema  
updates in these minor revisions.

But as the code part already has 2 votes +1 this time :)

jb

On 14 Sep 2009, at 16:13, Nyloth wrote:

> +1
>
> Nyloth
>
> 2009/9/14 <ri...@us...>
> Revision: 21487
>          http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=21487&view=rev
> Author:   ricks99
> Date:     2009-09-14 14:56:24 +0000 (Mon, 14 Sep 2009)
>
> Log Message:
> -----------
> [ENH]corrected filename. see 2147 and 21485
>
> Added Paths:
> -----------
>    branches/proposed/installer/schema/ 
> 20090913_plugin_security_addedby_tiki.sql
>
> Added: branches/proposed/installer/schema/ 
> 20090913_plugin_security_addedby_tiki.sql
> ===================================================================
> --- branches/proposed/installer/schema/ 
> 20090913_plugin_security_addedby_tiki 
> .sql                                (rev 0)
> +++ branches/proposed/installer/schema/ 
> 20090913_plugin_security_addedby_tiki.sql        2009-09-14 14:56:24  
> UTC (rev 21487)
> @@ -0,0 +1,2 @@
> +#ricks99
> +ALTER TABLE tiki_plugin_security ADD added_by VARCHAR( 200 ) NULL  
> AFTER status;
> \ No newline at end of file
>
>
> This was sent by the SourceForge.net collaborative development  
> platform, the world's largest Open Source development site.
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008  
> 30-Day
> trial. Simplify your report design, integration and deployment - and  
> focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Tikiwiki-cvs mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008  
> 30-Day
> trial. Simplify your report design, integration and deployment - and  
> focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july_______________________________________________
> Tikiwiki-cvs mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs