Re: [Tikiwiki-devel] Plugin legacy parameters

[Jonny B. <tw...@no...>]

I was thinking of suggesting committing it as IMGNEW or something, but  
things occasionally get stuck being called something_new and they're  
quite hard to clean up afterwards... however in this case (for a very  
short time) i think it would be ok.

If it's not going to replace the old IMG plugin you could commit it  
straight to trunk (i reckon) as it won't break any existing behaviour,  
plus then you'll have more eyeballs on it than just mine - so more  
testing etc.

You choose - see you in one or other soon!

jonny

On 25 Aug 2009, at 18:32, lindon wrote:

> Good idea Jonny - I'll submit to the edit_fixup experimental branch.
> Perhaps I'll upload it under a different name for now, say IMGNEW,  
> until we
> put it into trunk or proposed (but let me know if you think this is  
> a bad
> idea). I'll also document the parameters on the doc site. It may be  
> this
> weekend before I can do it.
>
> I'll also start familiarizing myself with Plugin Alias to see if  
> this may
> offer some kind of solution.
>
> Thanks for your help!
> lindon
>
> On Tue, 25 Aug 2009 11:19:55 +0100, Jonny Bradley <tw...@no...>  
> wrote:
>> Hi Lindon
>>
>> This is a brave undertaking - thanks so much for tackling it!
>>
>> How about you use Plugin Aliases to "simulate" the old plugins? You
>> should be able to map the old params onto the new ones, or are there
>> some that aren't covered by the new one?
>>
>> Maybe you could commit your work so far into an experimental  
>> branch? I
>> just started one to try and rationalise the edit textareas etc called
>> edit_fixup - there shouldn't be any conflict there as i'm not  
>> planning
>> to do anything on plugins. I'm mainly dealing with tiki-editpage so
>> far only so your stuff would be welcome there.
>>
>> Plugin Aliases are a bit mystical, and under documented, but very
>> powerful once you get the hang on them!
>>
>> jonny
>>
>>
>>
>> On 25 Aug 2009, at 03:33, lindon wrote:
>>
>>> Hello,
>>>
>>> As discussed here, I'm rewriting the img plugin to combine features
>>> from various plugins that deal with images. In some cases parameters
>>> will be changing so I have reassigned these legacy parameters to the
>>> new ones so that they still work. To do this I've included the old
>>> parameters in the params array in the wikiplugin_img_info function
>>> since it seems that only parameters included here are recognized.
>>> But the problem is that this causes the legacy parameters to appear
>>> in the edit plugin popup screen, which I don't want because people
>>> shouldn't use these parameters going forward.
>>>
>>> Is there another way to do this, ie assign legacy parameters to the
>>> new ones but without including the legacy parameters in the params
>>> array or otherwise hiding them from the edit plugin popup?
>>>
>>> Thanks for your help,
>>>
>>> lindon
>>>
>>>
> ------------------------------------------------------------------------------
>>> Let Crystal Reports handle the reporting - Free Crystal Reports 2008
>>> 30-Day
>>> trial. Simplify your report design, integration and deployment - and
>>> focus on
>>> what you do best, core application coding. Discover what's new with
>>> Crystal Reports now.
>>>
> http://p.sf.net/sfu/bobj-july_______________________________________________
>>> Tikiwiki-devel mailing list
>>> Tik...@li...
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008  
> 30-Day
> trial. Simplify your report design, integration and deployment - and  
> focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Tikiwiki-devel mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel