Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[19090] branches/proposed

[Sylvie G. <sgr...@gm...>]

Jyhem,
I think it is a little more job before going to proposed

PHP (5.2.6) NOTICE (8):
File: tiki-admin_include_features.php
Line: 131
Type: Undefined index: feature_tabs
PHP (5.2.6) NOTICE (8):
File: tiki-admin_include_features.php
Line: 135
Type: Undefined index: tabbed_admin_features

Thanks
sylvie

On Tue, 2009-05-26 at 09:56 +0000, Jy...@us... wrote:
> Revision: 19090
>           http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=19090&view=rev
> Author:   Jyhem
> Date:     2009-05-26 09:56:23 +0000 (Tue, 26 May 2009)
> 
> Log Message:
> -----------
> [ENH] tab preference in admin_features is now maintained over session
> 
> Modified Paths:
> --------------
>     branches/proposed/templates/tiki-admin-include-features.tpl
>     branches/proposed/tiki-admin_include_features.php
> 
> Modified: branches/proposed/templates/tiki-admin-include-features.tpl
> ===================================================================
> --- branches/proposed/templates/tiki-admin-include-features.tpl	2009-05-26 09:52:35 UTC (rev 19089)
> +++ branches/proposed/templates/tiki-admin-include-features.tpl	2009-05-26 09:56:23 UTC (rev 19090)
> @@ -7,6 +7,7 @@
>  			<div class="heading input_submit_container" style="text-align: right">
>          {if $prefs.feature_tabs eq 'y'}
>            {tr}No tabs{/tr}
> +          <input type="hidden" name="feature_tabs" value="active" />
>            <input type="checkbox" name="tabs"{if $tabs eq 'n'} checked="checked"{/if} onclick="document.features.submit();"/>
>          {/if}  
>  				<input type="submit" name="features" value="{tr}Apply{/tr}" />
> 
> Modified: branches/proposed/tiki-admin_include_features.php
> ===================================================================
> --- branches/proposed/tiki-admin_include_features.php	2009-05-26 09:52:35 UTC (rev 19089)
> +++ branches/proposed/tiki-admin_include_features.php	2009-05-26 09:56:23 UTC (rev 19090)
> @@ -127,10 +127,13 @@
>  }
>  
>  if (!empty($_REQUEST['tabs'])) {
> -	$smarty->assign('tabs', $_REQUEST['tabs']=='on'?'n':'');
> +	$_SESSION["tabbed_admin_features"] = $_REQUEST['tabs']=='on'?'n':'' ;
>  } else {
> -	$smarty->assign('tabs', '');
> +	if( $_REQUEST["feature_tabs"] ) {	// Verifies that form was submitted
> +		$_SESSION["tabbed_admin_features"] = '' ;
> +	}
>  }
> +$smarty->assign('tabs', $_SESSION["tabbed_admin_features"]);
>  
>  $smarty->assign('php_major_version', substr(PHP_VERSION, 0, strpos(PHP_VERSION, '.')));
>  
> 
> 
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
> 
> ------------------------------------------------------------------------------
> Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
> is a gathering of tech-side developers & brand creativity professionals. Meet
> the minds behind Google Creative Lab, Visual Complexity, Processing, & 
> iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
> Group, R/GA, & Big Spaceship. http://www.creativitycat.com 
> _______________________________________________
> Tikiwiki-cvs mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs