Re: [Tikiwiki-cvs/svn] SF.net SVN: tikiwiki:[18024] branches/3.0/templates/tiki.tpl

[Jonny B. <tw...@no...>]

Hi Gary, Luci and all

The cleanest thing would be a Smarty var to show if we're in IE6?  
(hmmm debug console still broken - mustn't get distracted!)

Oh dear, ok, i seem to have got distracted - fix incoming... [18067]

Tested on IE6, but i couldn't see the difference between having this  
$ie6 smarty var set and not (with "user decides" on the columns?) What  
was the problem anyway?

At least it should validate ok now (but not checked)

Hope it helps,

jonny




On 17 Apr 2009, at 16:05, Gary Cunningham-Lee wrote:

> Hi luci,
>
> Hmm, ok. I just made the edit and ran it through the validator and  
> got a
> "congratulations - success" result
> (http://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fzukakakina.com%2Ftw3%2Ftiki-index.php 
> ),
> so committed the change. How, then, to give IE6 what it needs and be
> valid code, ie., how to target IE6 in inline CSS? If we have to choose
> between a method that causes a failure at the w3c validator and one  
> that
> doesn't, probably we should go with the one that doesn't. But the best
> would be 100% valid code that works with IE6 too.
>
> -- Gary
>
> luci aka luciash d' being wrote:
>> hi gary,
>>
>> sorry, but this is not solution... it invalidates anyway...  
>> attributes
>> cannot contain html comments as they're built from "<" and ">"
>> Tiki doesn't validate now either !
>>
>> luci
>>
>>
>> On 04/16/2009 04:43 AM, chi...@us... wrote:
>>
>>> Revision: 18024
>>>          http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=18024&view=rev
>>> Author:   chibaguy
>>> Date:     2009-04-16 02:43:41 +0000 (Thu, 16 Apr 2009)
>>>
>>> Log Message:
>>> -----------
>>> [FIX] Non-validating CSS for IE6 replaced with conditional comment.
>>>
>>> Modified Paths:
>>> --------------
>>>    branches/3.0/templates/tiki.tpl
>>>
>>> Modified: branches/3.0/templates/tiki.tpl
>>> ===================================================================
>>> --- branches/3.0/templates/tiki.tpl	2009-04-15 23:29:36 UTC (rev  
>>> 18023)
>>> +++ branches/3.0/templates/tiki.tpl	2009-04-16 02:43:41 UTC (rev  
>>> 18024)
>>> @@ -93,7 +93,7 @@
>>> 				</div>{* -- END of c1c2 -- *}
>>> {if $prefs.feature_fullscreen != 'y' or  
>>> $smarty.session.fullscreen != 'y'}
>>> 	{if $prefs.feature_right_column ne 'n' && $right_modules|@count >  
>>> 0 && $show_columns.right_modules ne 'n'}
>>> -				<div class="clearfix" id="col3"{if  
>>> $prefs.feature_right_column eq 'user'} style="display:{if  
>>> isset($cookie.show_rightcolumn) and $cookie.show_rightcolumn ne  
>>> 'y'} none{else} table-cell; _display: block{/if};"{/if}{if  
>>> $prefs.feature_bidi eq 'y'} dir="rtl"{/if}>
>>> +				<div class="clearfix" id="col3"{if  
>>> $prefs.feature_right_column eq 'user'} style="display:{if  
>>> isset($cookie.show_rightcolumn) and $cookie.show_rightcolumn ne  
>>> 'y'} none{else} table-cell; <!--[if IE 6]>display: block;<! 
>>> [endif]-->{/if}"{/if}{if $prefs.feature_bidi eq 'y'} dir="rtl"{/if}>
>>> 					<h2 class="hidden">Sidebar</h2>
>>> 					<div class="content">
>>> 		{section name=homeix loop=$right_modules}
>>>
>>>
>>> This was sent by the SourceForge.net collaborative development  
>>> platform, the world's largest Open Source development site.
>>>
>>> ------------------------------------------------------------------------------
>>> Stay on top of everything new and different, both inside and
>>> around Java (TM) technology - register by April 22, and save
>>> $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
>>> 300 plus technical and hands-on sessions. Register today.
>>> Use priority code J9JMT32. http://p.sf.net/sfu/p
>>> _______________________________________________
>>> Tikiwiki-cvs mailing list
>>> Tik...@li...
>>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs
>>>
>>>
>>>
>>
>> luci
>>
>> ------------------------------------------------------------------------
>>
>>
>> No virus found in this incoming message.
>> Checked by AVG - www.avg.com
>> Version: 8.5.287 / Virus Database: 270.11.59/2064 - Release Date:  
>> 04/17/09 07:08:00
>>
>>
>
>
> ------------------------------------------------------------------------------
> Stay on top of everything new and different, both inside and
> around Java (TM) technology - register by April 22, and save
> $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
> 300 plus technical and hands-on sessions. Register today.
> Use priority code J9JMT32. http://p.sf.net/sfu/p
> _______________________________________________
> Tikiwiki-cvs mailing list
> Tik...@li...
> https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs