[Tikiwiki-devel] Question about tikilib.php before committing

[Robert F. <rob...@ho...>]

Hey Everyone,

 

Some quick questions about files to commit:

 

I made my own changes to tikilib towards the end of parse_first to allow the youtube plugin URL to not be stripped of its equal sign, otherwise everything after it, the movie name, doesnt show up in the plugin. So this is what the original looks like:

 

foreach ($params as $param) {
      $parts = $this->quotesplit( '=>?', $param );

      if (isset($parts[0]) && isset($parts[1])) {
   $name = trim($parts[0]);
   $argument = trim($parts[1]);

 

 

...and with my changes:

 

 

foreach ($params as $param){
  //if the plugin is for YOUTUBE, then dont send to quotesplit or it will break the URL at the equals sign
  if(strstr($param, "youtube.com/watch?v=")){
   $parts[0] = 'movie';
   $parts[1] = str_replace("movie=>", "", $param);
  }else{
   $parts = $this->quotesplit( '=>?', $param );
  }
      
      if (isset($parts[0]) && isset($parts[1])) {
   $name = trim($parts[0]);
   $argument = trim($parts[1]);

 

 

Can I commit this? I also re-wrote the youtube plugin so that it follows the current format, the other one did, but its slightly different. I would be committing that too.

 

 

robferguson

_________________________________________________________________
The new Windows Live Messenger. You don’t want to miss this.
http://www.microsoft.com/windows/windowslive/products/messenger.aspx