Re: [Tikiwiki-devel] WikiPlugin $data being escaped (but not in preview)

[luci a. l. d' b. <sf...@gr...>]

hi,

+1 to fix it ! it's clear inconsistency bug and the preview should 
reflect what will be actually saved and not anything else...

thanks,

luci


On 06/12/08 02:43, Jeremy Lee wrote:
>> Hello Jeremy,
>>
>> I was not aware of this problem, however, I don't think it's likely a fix
>> will be released in the 2.x branch. Some plugins may rely on that.
>>     
>
> It's not the behavior that troubles me; it's the inconsistency. I don't
> mind if the $data has all it's characters escaped to HTML entities... it's
> the fact that it does it differently in preview mode. My next step in
> developing the plugin is to allow embedded HTML in the reports, and that's
> just not going to work very well.
>
> Is there a wiki variable somewhere that indicates which mode it's in?
> (Probably not, since ideally there shouldn't be a difference)
>
>   
>> completely possible to fix it for 3.0. There were many changes in the way
>> plugins are handled and there are a few more to come. I invite you to test
>> out your plugin on the development branch.
>>     
>
> Since I'm doing this for a production site, that's not really an option. I
> get the feeling that in one place the Wiki code says something like;
>
> $preview_result = htmlentities(plugin($data,$params));
>
> while somewhere else it's
>
> $page_result = plugin(htmlentities($data)),$params);
>
> And I'm willing to fix that bug in 2.x if someone can just point me at the
> relevant files. (There's a lot of code running TikiWiki, and I just don't
> have the time to learn it all.)
>
>   
>> You are also welcome to contribute to
>> the project. Just request commit access.
>>     
>
> I will probably do so once it's all stable. Give me a few weeks.
>
>