From: Pascal K. <pas...@gm...> - 2008-09-15 12:43:21
|
Hello Sylvie, 2008/9/15 Sylvie Greverend <sgr...@gm...> > pkdille, > > I thought we agreed on > > http://dev.tikiwiki.org/tiki-pagehistory.php?page=TemplatesBestPractices&preview=10 > see the devel discussion about this. --> I was just looking and found your mail and luci's answer in early august. As there where no commit (AFAIK) to explicitely change this structure, I just didn't remember this discussion ! > > > Why pkdille did you change this page? > > http://dev.tikiwiki.org/tiki-pagehistory.php?page=TemplatesBestPractices&compare=1&oldver=12&newver=13&diff_style=sidediff --> when you are looking in templates, it's (IMHO) mostly like this: <div class="navbar") <span class="button2"> /> <a class="linkbut" href=.....>...</a> </span> /> <span class="button2"> <a class="linkbut" href=.....>...</a> </span> </div> So, the idea was to deploy the version which is the most implemented (preserve environnment) and to have the same structure everywhere ! If everybody is agree with your version, I propose that the community deploys this version ;-)) > > > We really do not need all this classes. --> I'm agree with you. Anyway, we, in Strasbourg, will write a smarty plugin (as for title, remarksbox and pagination links, ...) and deploy it. So, in the future, changing the structure, or behaviour of all this "buttons" will be very easy. > > Can we reopen the discussion > --> done > > Thanks --> you're welcome > > Sylvie --> Pascal > > > > On Mon, 2008-09-15 at 09:45 +0000, pk...@us... wrote: > > Revision: 14705 > > > http://tikiwiki.svn.sourceforge.net/tikiwiki/?rev=14705&view=rev > > Author: pkdille > > Date: 2008-09-15 09:45:05 +0000 (Mon, 15 Sep 2008) > > > > Log Message: > > ----------- > > [MOD] formatting navbar in some templates > > > > Modified Paths: > > -------------- > > trunk/templates/tiki-directory_admin_bar.tpl > > trunk/templates/tiki-directory_bar.tpl > > > > Modified: trunk/templates/tiki-directory_admin_bar.tpl > > =================================================================== > > --- trunk/templates/tiki-directory_admin_bar.tpl 2008-09-15 02:15:09 > UTC (rev 14704) > > +++ trunk/templates/tiki-directory_admin_bar.tpl 2008-09-15 09:45:05 > UTC (rev 14705) > > @@ -1,8 +1,32 @@ > > -<div class="navbar" id="page-bar"> > > - <a class="linkbut" href="tiki-directory_browse.php" > class="linkbut">{tr}Browse{/tr}</a> > > - <a class="linkbut" href="tiki-directory_admin.php" > class="linkbut">{tr}Admin{/tr}</a> > > - {if $tiki_p_admin_directory_cats eq 'y'}<a class="linkbut" > href="tiki-directory_admin_categories.php" > class="linkbut">{tr}Categories{/tr}</a>{/if} > > - {if $tiki_p_admin_directory_cats eq 'y'}<a class="linkbut" > href="tiki-directory_admin_related.php" > class="linkbut">{tr}Related{/tr}</a>{/if} > > - {if $tiki_p_admin_directory_sites eq 'y'}<a class="linkbut" > href="tiki-directory_admin_sites.php" > class="linkbut">{tr}Sites{/tr}</a>{/if} > > - {if $tiki_p_validate_links eq 'y'}<a class="linkbut" > href="tiki-directory_validate_sites.php" > class="linkbut">{tr}Validate{/tr}</a>{/if} > > +<div class="navbar"> > > + <span class="button2"> > > + <a class="linkbut" > href="tiki-directory_browse.php">{tr}Browse{/tr}</a> > > + </span> > > + <span class="button2"> > > + <a class="linkbut" > href="tiki-directory_admin.php">{tr}Admin{/tr}</a> > > + </span> > > + > > + {if $tiki_p_admin_directory_cats eq 'y'} > > + <span class="button2"> > > + <a class="linkbut" > href="tiki-directory_admin_categories.php">{tr}Categories{/tr}</a> > > + </span> > > + {/if} > > + > > + {if $tiki_p_admin_directory_cats eq 'y'} > > + <span class="button2"> > > + <a class="linkbut" > href="tiki-directory_admin_related.php">{tr}Related{/tr}</a> > > + </span> > > + {/if} > > + > > + {if $tiki_p_admin_directory_sites eq 'y'} > > + <span class="button2"> > > + <a class="linkbut" > href="tiki-directory_admin_sites.php">{tr}Sites{/tr}</a> > > + </span> > > + {/if} > > + > > + {if $tiki_p_validate_links eq 'y'} > > + <span class="button2"> > > + <a class="linkbut" > href="tiki-directory_validate_sites.php">{tr}Validate{/tr}</a> > > + </span> > > + {/if} > > </div> > > > > Modified: trunk/templates/tiki-directory_bar.tpl > > =================================================================== > > --- trunk/templates/tiki-directory_bar.tpl 2008-09-15 02:15:09 UTC > (rev 14704) > > +++ trunk/templates/tiki-directory_bar.tpl 2008-09-15 09:45:05 UTC > (rev 14705) > > @@ -1,22 +1,34 @@ > > -<div class="navbar" id="page-bar"> > > -<table> > > -<tr> > > -{if $tiki_p_admin_directory_cats eq 'y' or $tiki_p_admin_directory_sites > eq 'y' or $tiki_p_validate_links eq 'y'} > > -<td><div class="button2"><a href="tiki-directory_admin.php" > class="linkbut">{tr}Admin{/tr}</a></div></td> > > -{/if} > > -{if $mid ne "tiki-directory_browse.tpl"} > > -<td><div class="button2"><a href="tiki-directory_browse.php" > class="linkbut">{tr}Browse{/tr}</a></div></td> > > -{/if} > > -<td><div class="button2"><a > href="tiki-directory_ranking.php?sort_mode=created_desc" > class="linkbut">{tr}New Sites{/tr}</a></div></td> > > -{if $prefs.directory_cool_sites eq "y"} > > -<td><div class="button2"><a > href="tiki-directory_ranking.php?sort_mode=hits_desc" > class="linkbut">{tr}Cool Sites{/tr}</a></div></td> > > -{/if} > > -{if $tiki_p_submit_link eq 'y' or $tiki_p_autosubmit_link eq 'y'} > > -<td><div class="button2"><a href="tiki-directory_add_site.php{if > isset($addtocat)}?addtocat={$addtocat}{/if}" class="linkbut">{tr}Add a > Site{/tr}</a></div></td> > > -{if $tiki_p_admin_directory_cats eq 'y'} > > -<td><div class="button2"><a href="tiki-directory_admin_categories.php" > class="linkbut">{tr}Add a Category{/tr}</a></div></td> > > -{/if} > > -{/if} > > -</tr> > > -</table> > > +<div class="navbar"> > > + {if $tiki_p_admin_directory_cats eq 'y' or > $tiki_p_admin_directory_sites eq 'y' or $tiki_p_validate_links eq 'y'} > > + <span class="button2"> > > + <a href="tiki-directory_admin.php" > class="linkbut">{tr}Admin{/tr}</a> > > + </span> > > + {/if} > > + > > + {if $mid ne "tiki-directory_browse.tpl"} > > + <span class="button2"> > > + <a href="tiki-directory_browse.php" > class="linkbut">{tr}Browse{/tr}</a> > > + </span> > > + {/if} > > + > > + <span class="button2"> > > + <a > href="tiki-directory_ranking.php?sort_mode=created_desc" > class="linkbut">{tr}New Sites{/tr}</a> > > + </span> > > + > > + {if $prefs.directory_cool_sites eq "y"} > > + <span class="button2"> > > + <a > href="tiki-directory_ranking.php?sort_mode=hits_desc" > class="linkbut">{tr}Cool Sites{/tr}</a> > > + </span> > > + {/if} > > + > > + {if $tiki_p_submit_link eq 'y' or $tiki_p_autosubmit_link eq 'y'} > > + <span class="button2"> > > + <a href="tiki-directory_add_site.php{if > isset($addtocat)}?addtocat={$addtocat}{/if}" class="linkbut">{tr}Add a > Site{/tr}</a> > > + </span> > > + {if $tiki_p_admin_directory_cats eq 'y'} > > + <span class="button2"> > > + <a > href="tiki-directory_admin_categories.php" class="linkbut">{tr}Add a > Category{/tr}</a> > > + </span> > > + {/if} > > + {/if} > > </div> > > > > > > This was sent by the SourceForge.net collaborative development platform, > the world's largest Open Source development site. > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > > Build the coolest Linux based applications with Moblin SDK & win great > prizes > > Grand prize is a trip for two to an Open Source event anywhere in the > world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > Tikiwiki-cvs mailing list > > Tik...@li... > > https://lists.sourceforge.net/lists/listinfo/tikiwiki-cvs > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Tikiwiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > |