From: Rodrigo S. P. <rod...@gm...> - 2008-07-31 14:39:34
|
Hi Nyloth, ok for making "Wiki authors style" optional and thanks for the information about the new way for handling translation :-) Just one more think to consider. What do you think if we organize in the language.php so that strings like 'Login' and 'Login:' are put together? Not sure if this is hard to implement in get_strings.php or if it will make thinks harder in some way. I'm just thinking in a way to alert translators that they don't need to translate some strings in language.php. Other ideas? Cheers, Rodrigo. On Tue, Jul 29, 2008 at 12:00 PM, Nyloth <ny...@ti...> wrote: > Hi Rodrigo, > > On Tuesday 29 July 2008 16:27:22 Rodrigo Sampaio Primo wrote: > > Hi Nyloth, I also think that the "Wiki authors style for each page" > should > > be optional and off by default. If there is no time to do this, we should > > move this new feature to trunk. What do you think? > > I agree (for the optional part). There is less work to make it optionnal > compared to remove completely the feature. I'll try to do something > quickly. > > > And about the new way for handling ':' char I would appreciate if you > could > > explain it. For me the problem is that now there are two almost identical > > strings to translate. Like "History" and "History:" or "Similar" and > > "Similar:". There is a good reason for having the ':' char inside the > > string? From the translator point of view this change represent more work > > I think you misunderstood my change. In fact, it is intended to _reduce_ > the > number of strings to translate. You only have to translate "History", > not "History:" anymore, even if both are used in the templates... > > I tried to explain this in my commit message, but it might not have been > clear > enough : > > ------------------------------------------------------------------------ > r13361 | nyloth | 2008-06-26 16:57:38 +0200 (jeu, 26 jun 2008) | 5 lines > > [NEW] translation system : Now, if no translation has been found for > strings > which ends with a punctuation char like : ! or ; then try to translate > punctuation separately (e.g. if the content is 'Login:' or 'Login :', then > it > will try to translate 'Login' and ':' separately). This should avoid > duplicated strings like 'Login' and 'Login:' that were needed before > (because > there is no space before ':' in english, but there is one in others like > french). > > I hope this will stop the endless nightmare to decide weither to put the > ':' > inside or outside the string to translate (now, we should put it inside the > string between smarty {tra}{/tra} or when using php tra() function, but not > in the language.php file). > ------------------------------------------------------------------------ > > There was also some comments added by Jyhem in get_strings.php (and they > should be automatically added to each language.php that are regenerated > from > get_strings) : > > ### Note for translators about translation of text ending with colons (':') > ### > ### Short version: it is not a problem that string "Login:" has no > translation. Only "Login" needs to be translated. > ### > ### Technical justification: > ### If a string ending with colon needs translating (like > "{tr}Login:{/tr}") > ### then TikiWiki tries to translate 'Login' and ':' separately. > ### This allows to have only one translation for "{tr}Login{/tr}" > and "{tr}Login:{/tr}" > ### and it still allows to translate ":" as " :" for languages that > ### need it (like french) > > ------------------------------------------------------------------------- > > I even commented the code of the tra() function : > > // If no translation has been found and if the string ends with a > punctuation, > // try to translate punctuation separately (e.g. if the content is > 'Login:' > or 'Login :', > // then it will try to translate 'Login' and ':' separately). > // This should avoid duplicated strings like 'Login' and 'Login:' that were > needed before > // (because there is no space before ':' in english, but there is one in > others like french) > > > If you need more explanations, feel free to ask, > > Nyloth. > |