Re: [Tikiwiki-devel] Submitting code changes

[Marc L. <ma...@ma...>]

Josef Drexler wrote:

>
> Hi,
>
> I've made a bunch of modifications to tikiwiki 1.9.2 for my own wiki, 
> and was wondering if/how I should submit them for inclusion in tikiwiki.
>
> This is what I changed:
>
> - changed character diff to word-based diff, the character diff was
>   creating very silly differences


Nice.

> - new diff option "inline", like side-by-side but only one column showing
>   additions and removals
>
> for an example of the above see 
> http://wiki.ttdpatch.net/tiki-pagehistory.php?page=Action0Trains&diff_style=mininlinediff&oldver=45&newver=48&compare=1 
>


more diffs -> good.


>
> - changed !/!!/etc headings to produce stable <A NAME="..."> anchors to
>   allow linking to them (using the urlencode form of the header line)
> - changed {maketoc} to use these anchors instead of randomly generated
>   ones


I have always wondered about these randomly generated anchors. I see no 
use to them. It is annoying because if you change your page headings, 
you need to update the anchors... Can someone give me a good reason why 
we should't switch to this new behavior?


> - allowed explicit ((...)) links to use anchors, such as
>   ((Action0GeneralVariables#Cargo+translation+table+%2809%29|cargo
>   translation table))

I like it.  Is this risky?

In external links, are # allowed?

>
> for an example of this see 
> http://wiki.ttdpatch.net/tiki-index.php?page=Action0Cargos
> there is an anchor link under headings "Cargo classes (16)" and "Cargo 
> label (17)"


Excellent!

>
> - when the wiki option "Open page as structure" is enabled, make the
>   structure header on each page use page=foo instead of page_id=bar
>   for linking the relative pages (for more consistent URLs)

Not sure this is what I think it is. But +1 for more consistant & 
meaningful URLs.

> - in "Last Changes" box, remove useless order number and replace it with
>   age of change

interesting.

> - changed {toc} to add page description on page, not just link title
>
> all of these can be seen at e.g. 
> http://wiki.ttdpatch.net/tiki-index.php?page=AdditionalReferences
>
> I'd be interested to hear which of these might be of interest to the 
> tikiwiki community.
>

Josef: All your changes fit in nicely to make Tiki more user-friendly 
and powerful. Please do contribute all these changes and any others you 
may develop in the future.

BRANCH-1-9 is for bugfixes
HEAD is for new features

However, if you have a minor feature/interface enhancement, which 
doesn't affect the database and you are confident it won't introduce bad 
bugs, please add to BRANCH-1-9 and it will be part of Tiki 1.9.3 

Please join us on #tikiwiki

Best regards,

M ;-)