tigefa4u projects Trac

WikiRename: added a functional test for the wiki rename operation

- create wiki page with one attachment
- try a few pathological rename (to itself, to existing page)
- do a real rename, leaving a redirection page in place
- check for the attachment move, for the redirection page
- do another real rename, this time without redirection
- check the original page is gone

WikiRename (rebasing r6424, r6497): add the possibility to leave a redirection page for pointing to the renamed page.

This is admittedly a poor way to fix dangling links, but perhaps the most effective one in the current state, as it's not really possible for now to go back to all the wiki texts (on wiki pages, tickets, ...) that may contain a link to the old page and update them.

WikiRename (rebasing r6423, r6496): add a simple user interface for renaming wiki pages.

The interface was modeled after the one for deleting wiki pages, i.e. with a confirmation page that asks for the additional details.

WikiRename: added unit-test for `WikiPage.rename`.

- set correctly the `WikiPage.name` property after the rename
- add `old_name` parameter to `page_renamed` listener method

WikiRename (rebasing r6422): add a method to the model for renaming a wiki page in-place.

New methods:
- `WikiPage.rename(self, new_name, db=None)`
- `Attachment.reparent_all(cls, env, old_realm, old_id, new_realm, new_id, db)`

Implementation note for `Attachment.reparent_all`: we move files individually instead of the whole folder, because:
1. this will work even if the new resource already exists (e.g. for merges)
2. it's complex when the new resource is a sub-folder if the old one
3. it's simply not possible in the general case (e.g. when the new page doesn'titself exist, but there are already sub-folders)

Note also that it's because of 3. (sub-folders may exists) that we don't remove the old attachment folder after the reparent.

WikiRename (rebasing r6421): simplify transaction handling in the Wiki model

The !WikiPage public API is not modified. A helper `transaction` function is used to factor out the `handle_ta` business. Its usage is very simple:
- if the function is given a database connection, it will simply execute the callback as part of another transaction,
- if the function has to retrieve a new database connection, it takes responsibility to either `commit` the changes performed by the callback or to `rollback` them, if any exception was raised.

TODO: similar changes could apply to `trac.ticket.model`

Recreate WikiRename branch for rebasing log:sandbox/wiki-rename@...

0.12dev: merged revisions r7320 and r7327 from 0.11-stable (r7325 was already merged), via svnmerge.

Rebase WikiRename branch

Retiring old [VcRefactoring/Controller] branch