Merged revisions 5432-5458 via svnmerge from
https://svn.edgewall.org/repos/trac/trunk
........
r5435 | cboos | 2007-05-19 05:06:01 -0400 (Sat, 19 May 2007) | 1 line
Little clarification of the ticket model save method.
........
r5436 | cboos | 2007-05-19 06:10:36 -0400 (Sat, 19 May 2007) | 1 line
Add distinctive ''closed'' style for TracLinks to completed milestones.
........
r5437 | cboos | 2007-05-19 06:24:33 -0400 (Sat, 19 May 2007) | 1 line
Fix typo in query RSS export method.
........
r5438 | cboos | 2007-05-19 09:20:22 -0400 (Sat, 19 May 2007) | 5 lines
WorkFlow: enhanced the documentation and a few formatting cleanups.
In particular, I felt the need to clarify ''state'' vs. ''status''.
In many places, we were talking about ticket states referring to the ticket state as a whole, not only to its ''status'' field. The `ITicketActionController.get_all_states` method on the other hand was about getting the different values for the ''status'' fields, so I renamed the ITicketActionController method to `get_all_status`.
........
r5439 | cboos | 2007-05-19 10:58:12 -0400 (Sat, 19 May 2007) | 2 lines
WorkFlow: the `get_ticket_changes` and `apply_action_side_effects` methods of the ITicketActionController interface, like the `render_ticket_action_control` one, where intended to be called only on the controllers that actually declared to handle the `action` being performed.
........
r5440 | cboos | 2007-05-19 11:26:11 -0400 (Sat, 19 May 2007) | 1 line
WorkFlow: follow-up to r5439, the check for matching action controllers was not correct.
........
r5441 | cboos | 2007-05-19 11:27:50 -0400 (Sat, 19 May 2007) | 1 line
WorkFlow: move the default workfow implementation out of the API file.
........
r5442 | cboos | 2007-05-19 11:38:21 -0400 (Sat, 19 May 2007) | 17 lines
WorkFlow: renamed the '''!DefaultTicketActionController''' component to '''!ConfigurableTicketWorkflow'''
''Note that if you already have multiple controllers configured, you should do the same rename in your trac.ini file''
e.g. from:
{{{
[ticket]
workflow = DefaultTicketActionController,CodeReviewActionController,StatusFixerActionController
}}}
to:
{{{
[ticket]
workflow = ConfigurableTicketWorkflow,CodeReviewActionController,StatusFixerActionController
}}}
........
r5443 | cboos | 2007-05-19 13:19:54 -0400 (Sat, 19 May 2007) | 1 line
WorkFlow: follow-up to the r5442 move. ''Note that those sample plugins are still not operational as they're already matching the future API for get_ticket_changes which should come shortly (in r5444 if all goes well)''
........
r5444 | cboos | 2007-05-20 05:53:41 -0400 (Sun, 20 May 2007) | 10 lines
WorkFlow: some interface changes for the ITicketActionController
- `render_ticket_action_control` returns now a `(label, control, hint)` tuple.
The `hint` will be used to inform the user about what will happen if the action is performed.
- `get_ticket_changes` now returns simply the dictionary containing the ticket changes, instead of that dictionary plus a description of the change. That description was barely used (only by one sample plugin), and if there's a need to warn the user, the standard `req.warning` mechanism will achieve the same effect.
Also:
- further improvements to the documentation
- adapt the sample plugins to the above API changes (well, for those not already anticipating it!)
- the !CodeReview sample plugin has also been refactored a bit
........
r5445 | cboos | 2007-05-20 06:26:23 -0400 (Sun, 20 May 2007) | 1 line
Fixing if/when confusion in the error template.
........
r5446 | cboos | 2007-05-20 06:47:04 -0400 (Sun, 20 May 2007) | 1 line
WorkFlow to convert the 'conflicting changes detected' error into a warning.
........
r5447 | cboos | 2007-05-20 07:10:58 -0400 (Sun, 20 May 2007) | 1 line
WorkFlow: continue to transform the controllor conflicting changes error into a warning
........
r5448 | cboos | 2007-05-20 09:12:45 -0400 (Sun, 20 May 2007) | 1 line
Stylistic change, use ''in'' keyword inside of ''has_key'' method
........
r5449 | cboos | 2007-05-20 10:13:20 -0400 (Sun, 20 May 2007) | 5 lines
Previewing or saving a new ticket or ticket changes won't trigger an error when there are some problems with the changes. Instead, it will revert to previewing mode along with one warning for each particular issue.
This addresses the #1146 issue as well as the #4100 one, as the user provided data can't be lost anymore.
All the validations are now done in the `_validate_ticket` method.
........
r5450 | cboos | 2007-05-20 11:57:58 -0400 (Sun, 20 May 2007) | 1 line
WorkFlow: follow-up to r5447, the check for conflicting controller changes was done too late in _do_save. Do it earlier and make sure it's done only once.
........
r5451 | cboos | 2007-05-20 11:59:01 -0400 (Sun, 20 May 2007) | 1 line
WorkFlow: warn about some special ''action'' keys used for non-workflow related tasks.
........
r5452 | cboos | 2007-05-20 12:02:36 -0400 (Sun, 20 May 2007) | 1 line
Refactor the ticket change display into a template macro.
........
r5453 | cboos | 2007-05-20 12:40:53 -0400 (Sun, 20 May 2007) | 8 lines
Improved the layout of the ticket preview
So far, the preview was redirecting to the change preview block, which was at the bottom of the ticket ''Change History'' block. While this had the merit to show the change entry in the place it will take after the change is saved, this was a bit far away the top of the page, which also contains useful informations for the preview:
- the occasional warnings in case of problems with the change
- the new values for the ticket fields, among which the ticket description
Therefore, I moved that change preview block upward, just above the ticket box.
........
r5454 | cboos | 2007-05-20 13:13:28 -0400 (Sun, 20 May 2007) | 1 line
Improved rendering of the Ticket preview, which now better matches the one of the Wiki preview.
........
r5455 | cboos | 2007-05-20 13:56:03 -0400 (Sun, 20 May 2007) | 1 line
Remember #2703 and the reply-below.diff? Well, here's another try. This is also to be consistent with the upcoming change adding more inline buttons to the description area.
........
r5456 | cboos | 2007-05-20 14:15:17 -0400 (Sun, 20 May 2007) | 1 line
Add an up link back to parent resource, on attachment and attachment list pages. Fixes #4701.
........
r5457 | cboos | 2007-05-20 16:34:53 -0400 (Sun, 20 May 2007) | 8 lines
Added ticket cloning feature (#4686)
The ''Clone'' button is placed in the ticket box, next to the ''Reply'' one.
Note that this request uses a ''post'' method and not a ''get'' because using ''get'' doesn't work well with IE and Opera (previewing or saving a cloned ticket will fail).
Though there's no special right needed besides TICKET_CREATE, this feature is mainly useful only for TICKET_ADMINs that have to track the same issue in different line of development, so the feature will only be available to them.
........
r5458 | cboos | 2007-05-21 02:15:07 -0400 (Mon, 21 May 2007) | 1 line
TicketQuery macro returns now ''No results'' when the query doesn't match any ticket (except in ''count'' mode where it shows 0 as usual). Closes #3293.
........
