tigefa4u projects Trac

Previewing or saving a new ticket or ticket changes won't trigger an error when there are some problems with the changes. Instead, it will revert to previewing mode along with one warning for each particular issue.

This addresses the #1146 issue as well as the #4100 one, as the user provided data can't be lost anymore.

All the validations are now done in the `_validate_ticket` method.

Stylistic change, use ''in'' keyword inside of ''has_key'' method

WorkFlow: continue to transform the controllor conflicting changes error into a warning

WorkFlow to convert the 'conflicting changes detected' error into a warning.

Fixing if/when confusion in the error template.

WorkFlow: some interface changes for the ITicketActionController

- `render_ticket_action_control` returns now a `(label, control, hint)` tuple.
The `hint` will be used to inform the user about what will happen if the action is performed.
- `get_ticket_changes` now returns simply the dictionary containing the ticket changes, instead of that dictionary plus a description of the change. That description was barely used (only by one sample plugin), and if there's a need to warn the user, the standard `req.warning` mechanism will achieve the same effect.

Also:
- further improvements to the documentation
- adapt the sample plugins to the above API changes (well, for those not already anticipating it!)
- the !CodeReview sample plugin has also been refactored a bit

WorkFlow: follow-up to the r5442 move. ''Note that those sample plugins are still not operational as they're already matching the future API for get_ticket_changes which should come shortly (in r5444 if all goes well)''

WorkFlow: renamed the '''!DefaultTicketActionController''' component to '''!ConfigurableTicketWorkflow'''

''Note that if you already have multiple controllers configured, you should do the same rename in your trac.ini file''

e.g. from:
{{{
[ticket]
workflow = DefaultTicketActionController,CodeReviewActionController,StatusFixerActionController
}}}

to:
{{{
[ticket]
workflow = ConfigurableTicketWorkflow,CodeReviewActionController,StatusFixerActionController
}}}

WorkFlow: move the default workfow implementation out of the API file.

WorkFlow: follow-up to r5439, the check for matching action controllers was not correct.