[Thoggen-cvs] SF.net SVN: thoggen: [283] trunk/thoggen

[<tp...@us...>]

Revision: 283
          http://thoggen.svn.sourceforge.net/thoggen/?rev=283&view=rev
Author:   tp-m
Date:     2007-12-25 05:36:37 -0800 (Tue, 25 Dec 2007)

Log Message:
-----------
	* src/th-job.c: (job_check_free_disk_space),
	  (job_create_pipeline_setup_tagging), (job_create_pipeline):
	  Remove some old cruft, add some FIXMEs.

Modified Paths:
--------------
    trunk/thoggen/ChangeLog
    trunk/thoggen/src/th-job.c

Modified: trunk/thoggen/ChangeLog
===================================================================
--- trunk/thoggen/ChangeLog	2007-12-23 19:05:31 UTC (rev 282)
+++ trunk/thoggen/ChangeLog	2007-12-25 13:36:37 UTC (rev 283)
@@ -1,3 +1,9 @@
+2007-12-25  Tim-Philipp Müller  <tim at centricular dot net>
+
+	* src/th-job.c: (job_check_free_disk_space),
+	  (job_create_pipeline_setup_tagging), (job_create_pipeline):
+	  Remove some old cruft, add some FIXMEs.
+
 2007-12-23  Tim-Philipp Müller  <tim at centricular dot net>
 
 	* src/th-job-progress-dialog.c: (th_job_progress_dialog_run_jobs):

Modified: trunk/thoggen/src/th-job.c
===================================================================
--- trunk/thoggen/src/th-job.c	2007-12-23 19:05:31 UTC (rev 282)
+++ trunk/thoggen/src/th-job.c	2007-12-25 13:36:37 UTC (rev 283)
@@ -1725,9 +1725,7 @@
 	return TRUE; /* call us again */
 }
 
-/* FIXME: why do we need to do this in the state change callback? */
 static void
-//job_pipeline_tag_setter_state_change_cb (ThJob *j, guint old_state, guint new_state, GstElement *element)
 job_pipeline_tag_setter_setup (ThJob *j, GstElement *element)
 {
 	if (!GST_IS_TAG_SETTER (element))
@@ -1765,28 +1763,12 @@
 job_create_pipeline_setup_tagging (ThJob *j, GstBin *pipeline)
 {
 	GstElement *tagsetter;
-#if 0
-	/* FIXME: don't leak references returned by _bin_get_by_name */
-	g_signal_connect_swapped (gst_bin_get_by_name (pipeline, "mux"),
-	                          "state-change",
-	                          G_CALLBACK (job_pipeline_tag_setter_state_change_cb),
-	                          j);
-
-	g_signal_connect_swapped (gst_bin_get_by_name (pipeline, "a-encoder"),
-	                          "state-change",
-	                          G_CALLBACK (job_pipeline_tag_setter_state_change_cb),
-	                          j);
-
-	g_signal_connect_swapped (gst_bin_get_by_name (pipeline, "v-encoder"),
-	                          "state-change",
-	                          G_CALLBACK (job_pipeline_tag_setter_state_change_cb),
-	                          j);
-#endif
 	/* FIXME: maybe do this by recursing into the pipeline
 	 * instead of picking out the elements by name? */
 	tagsetter = gst_bin_get_by_name (pipeline, "mux");
 	job_pipeline_tag_setter_setup (j, tagsetter);
         gst_object_unref (tagsetter);
+	/* FIXME: fix for multiple languages where encoder name is enumerated */
 	tagsetter = gst_bin_get_by_name (pipeline, "a-encoder");
 	job_pipeline_tag_setter_setup (j, tagsetter);
         gst_object_unref (tagsetter);
@@ -2010,7 +1992,7 @@
 
 	job_create_pipeline_setup_video_encoder (j);
 
-	/* vorbisenc */
+	/* vorbisenc (FIXME: fix for multiple languages) */
 	th_bin_set_child_properties (GST_BIN (pipe), "a-encoder",
 	              "bitrate", j->priv->audio_bitrate * 1000,
 	              "managed", TRUE, 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.