#316 Does not display with Firefox 3.5.2

[Gilles Carpentier]

I get the following erreur with the new version of Firefox (3.5.2) on Mac OS X (10.5.7) :

Erreur : missing ; before statement
Fichier Source : http://localhost:8080/webERP/?_twr_=ThinWire_v1.2_RC2.js
Ligne : 1160, Colonne : 15
Code Source :
this[eW]=realSetter

Thanks,
Gilles Carpentier

[James Pether Sörling]

Look at http://sourceforge.net/forum/forum.php?thread_id=3309103&forum_id=584240 , used that fix myself. Jar at http://edemocrazy.svn.sourceforge.net/viewvc/edemocrazy/repository/trunk/com/thinwire/thinwire/1.2_r677_cia/ , contains another small change to Image & ImageInfo..

[James Pether Sörling]

Sorry, should mention it fixes by FF by disable Animation.js so not good if you use animations.

[Clinton Lee]

It appears that the compressed code generated by thinwire-jso is not compatable with Mozilla 3.5.

Today, I have been experimenting with using Yahoo's yui-compressor to do the same/similar thing in the build process. I have it successfully building, I just want to look at the code size, etc. and then see weather its worth it in the long run.

One advantage of that is that then we don't have to maintain the jso minimization, but rather, just get the new uyui-compressor if needed.

If the size difference is neglegent I will post the changes needed here and we can decide if we will go with this option for thinwire.

Please let me know your thoughts.

[Nobody/Anonymous]

Hi all,

Ok, if we use Yahoo's yui compressor, the total javascript size is: 167,628 bytes (164K), on the other hand, the thinwire-jso is: 162,379 bytes (159K) So there is around 5K extra added this way.

BUT....

Since its gzipped most of the time going over the wire, the yui-compressor version is actualler SMALLER 38,776 (38K) compared to the thinwire-jso version gzipped 44,111 (43K)!

So I will clean up the build patch & info and post it back here when I have.

[Clinton Lee]

Sorry, I don't know how to add an attachment, but here is the patch to build.xml to use the yui-compressor.

Also, you need to add the yui compressor and dependant libraries to the build/yuicompressor-2.4.2 directory. I think I have commit access to this project, so I can commit it if you like.

Index: build.xml

--- build.xml (revision 512)
+++ build.xml (working copy)
@@ -78,7 +78,8 @@
</target>

<!-- Compile the framework, create a jar and create a distribution zip -->
- <target name="dist" depends="-init,-compile,-jso,-jar,-zip,-clean"/>
+ <!-- target name="dist" depends="-init,-compile,-jso,-jar,-zip,-clean"/ -->
+ <target name="dist" depends="-init,-compile,-jso,-jar,-zip,-clean" />

<!-- Compile the framework, create a jar, translate to Java 1.4 and create a distribution zip -->
<target name="dist14" depends="-init,-compile,-jso,-retroweaver,-jar,-zipJava14,-clean"/>
@@ -104,6 +105,7 @@
</target>

<target name="-jso">
+ <!--
<echo message="Applying ThinWire JavaScript Optimizer for Smaller Client-Side Code"/>

<taskdef name="jso" classname="thinwire.tools.jso.AntTask">
@@ -116,10 +118,20 @@
<include name="thinwire/render/web/resources/*.js"/>
<include name="thinwire/ui/layout/resources/*.js"/>
</jso>
-
-
- <!--<jso srcdir="" destdir="${path.temp}"
- includes="/thinwire/render/web/resources/*.js;/thinwire/ui/layout/resources/*.js"/>-->
+ -->
+ <echo message="Applying YUI Javascript Compressor for Smaller Client-Side Code" />
+ <apply executable="java" force="true">
+ <arg value="-jar" />
+ <arg file="../build/yuicompressor-2.4.2/yuicompressor-2.4.2.jar" />
+ <arg value="-o" />
+ <targetfile/>
+ <srcfile/>
+ <fileset dir="${path.temp}">
+ <include name="thinwire/render/web/resources/*.js" />
+ <include name="thinwire/ui/layout/resources/*.js"/>
+ </fileset>
+ <mapper type="glob" from="*.js" to="${path.temp}/*.js" />
+ </apply>
</target>

<target name="-retroweaver">