#684 Enhancement: MetronomeMark should support break-align-symbols

[Anonymous]

Originally created by: *anonymous

Originally created by: v.villenave
Originally owned by: jan.nieuwenhuizen

% The "break-align-symbols" is supported for BarNumber and
% RehearsalMark but not for MetronomeMark:

{
\override Score.BarNumber #'break-align-symbols = #'(clef)
\override Score.RehearsalMark #'break-align-symbols = #'(key-signature)

%"break-align-symbols" is not supported for MetronomeMark.
%...this line does nothing:
\override Score.MetronomeMark #'break-align-symbols = #'(time-signature)

\key es \major
\set Score.currentBarNumber = #10 \bar ""
\mark 1
\tempo Allegro
c''
}

% see also
% http://lists.gnu.org/archive/html/lilypond-devel/2008-09/msg00184.html
% and
% http://lists.gnu.org/archive/html/lilypond-devel/2008-06/msg00209.html

% Neil has posted a patch (attached), but:
% "the stumbling block is how to align to note columns; I can't
% work out how the metronome marks get attached to a paper column
% when there's no breakable object nearby."

[Google Importer]

Originally posted by: jan.nieuwenhuizen

Fixed, as per - http://codereview.appspot.com/1579041

One niggle/=feature request wrt multi-measure-rest placement remains.

Status: Fixed

[Google Importer]

Originally posted by: percival.music.ca@gmail.com

(No comment was entered for this change.)

Labels: fixed_2_13_32

[Google Importer]

Originally posted by: x.sche...@gmail.com

Is it really fixed?
Last comment from Neil is less than one day ago (whereas Jan's "fixed"
statement is 6 days ago).
http://codereview.appspot.com/1579041/

[Google Importer]

Originally posted by: n.putt...@gmail.com

It should be fine once I push this patch: http://codereview.appspot.com/2042043/

I've just got to sort out a few tweaks to one of the regression tests before committing.

[Google Importer]

Originally posted by: brownian.box@gmail.com

Thank all of you!

Status: Verified

[Google Importer]

Originally posted by: jan.nieuwenhuizen

Now that this bug is *really* fixed, we have to handle bounties.

   Jordi: E 50  (paid to Jan)
   Xavier: E 60 (paid to Jan)
   Kieren: E 111 ($150 CDN)

Considering the amount of work that Neil has done, I suggest to
split the bounty rewards between Neil and me.  If you're all okay
with that then Kieren can pay Neil the $150 CDN, and we'd be fine.

This has sure been an interesting experience.  I strongly suggest
for all bounty offers to include a full .ly file that demonstrates
the desired functionality with a clear description in texinfo,
ready, to put into input/regression before starting any bounty
work. 

How about adding the sponsors and bounty amounts in there too,
see suggested patch attached.

[Google Importer]

Originally posted by: percival.music.ca@gmail.com

I do not think that adding "paid for" signs in our code is appropriate.

I do, however, very much approve of bounty offers including a full .ly file with clear description.