LilyIssues / Issues / #684 Enhancement: MetronomeMark should support break-align-symbols

Google Importer - 2008-10-06

Originally posted by: reinhold...@gmail.com

The main problem seems to be that
Metronome_mark_engraver::acknowledge_break_alignment is ALWAYS called, even if
there is no suitable breakable object (as specified in the break-align-symbols)
available. I don't know of any way to detect when the default (paper column?) is
used and when a real breakable object is passed.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-05-05

Originally posted by: percival.music.ca@gmail.com

I don't believe this issue is still being worked on.

Owner: ---
Status: Accepted

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-05

Originally posted by: kie...@alumni.rice.edu

This is a high priority item for me and at least two other people.

Labels: Bounty

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-05

Originally posted by: percival.music.ca@gmail.com

How much, in total, are you three willing to sponsor? (at least a ballpark figure
would be helpful)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-05

Originally posted by: percival.music.ca@gmail.com

argh, I forgot to mention -- I have a vague recollection of telling somebody that if
people just said "I'd pay for this" without giving any precise dollar amount, it
wasn't worth adding a "bounty" label. If my memory is correct, then this would
explain why most of your bounty offers never made it here.

Hmm, I forgot to check if the new CG 7 included a discussion of bounties. I'll go do
that now.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-05

Originally posted by: kie...@alumni.rice.edu

I personally offer CDN$150 for a full and correct implementation of
break-align-symbols on MetronomeMark. I will double that (i.e., CDN$300) if the fix
is for *arbitrary* Grobs.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-05

Originally posted by: x.sche...@gmail.com

You can add 50€ from me if \tempo correctly align on time signature
and handles multi-measure rests correctly.

This is actually my personal "most annoying issue" right now.

Sorry not to be able to sponsor more, student budget inside.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-05

Originally posted by: jordi.na...@gmail.com

Hi, I am willing to contribute €60 for this feature.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-07

Originally posted by: jan.nieuwenhuizen

I've taken a look at this and typed git cl upload.

I assumed that git cl would do the right thing and ask for an issue to attach
to, but it created a new one:

Issue created. URL: http://codereview.appspot.com/1579041

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-07

Originally posted by: jan.nieuwenhuizen

Also adding the patch and results here.

684.ly

684.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-07

Originally posted by: jan.nieuwenhuizen

@x.scheuer: please specify how the multimeasure rest problem is related to this
alignment issue. If it is unrelated, please open a new bug for that and (specify
the bounty accordingly).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-07

Originally posted by: jan.nieuwenhuizen

@kieren: please specify *arbitrary* grobs, please add a second .ly example that
shows another similar problematic grob that should be fixed by this patch.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-07

Originally posted by: jan.nieuwenhuizen

Removed patch, code followups on http://codereview.appspot.com/1579041
(can we link these somehow?)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-07

Originally posted by: kie...@alumni.rice.edu

MultiMeasureRestText is a perfect example of an "arbitrary grob" that should be
align-able. At the moment, the only three "align-worthy" grobs I can think of are
MetronomeMark, RehearsalMark, and MultiMeasureRestText...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-07

Originally posted by: kie...@alumni.rice.edu

Oh... +TextSpanner!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-07

Originally posted by: x.sche...@gmail.com

Great!
I had been grumbling about this issue for a dozen of months, and a
couple of hours after the bounties have been proposed a solution is
almost there! :)
Thanks Jan!

@jan: sorry, my bad. It is Issue 712, Valentin said it seems related.

BTW, how does your new "break-alignable" \tempo behaves when used
simultaneously to a \mark \default ? IMO the tempo indication should
align on the right side of the RehearsalMark, is it possible?

Thank you!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-07

Originally posted by: jan.nieuwenhuizen

@x.scheuer: apropos your BTW on marks, I'm attaching an example png of what
happens, but please add a .ly file of what you want if this doesn't answer
your question.

metro-mark.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-07

Originally posted by: jan.nieuwenhuizen

@kieren: can you open another issue for making

[MetronomeMark, RehearsalMark, and] MultiMeasureRestText and TextSpanner

all alignable, with a .ly example of what should happen? And are MetronomeMark
and RehearsalMark already done now?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-10

Originally posted by: jordi.na...@gmail.com

I still have not tested the patch, but it seems ok. As soon as I can I'll test it.

I have one question though, please excuse me if this is not the right place for asking it, how we are supposed to do the payment?

Thanks again.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-14

Originally posted by: jan.nieuwenhuizen

@jordi.nada10: please contact me for details

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-06-23

Originally posted by: nez...@gmail.com

(No comment was entered for this change.)

Labels: Patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-08-04

Originally posted by: n.putt...@gmail.com

(No comment was entered for this change.)

Owner: jan.nieuwenhuizen
Status: Started

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-08-21

Originally posted by: x.sche...@gmail.com

Hi!

The PATCH is OK, isn't it?
Could it be pushed?

Or, what's wrong?
Last message about this was from Neil on 10th August:
http://lists.gnu.org/archive/html/lilypond-devel/2010-08/msg00120.html

Jan?

Cheers,
Xavier

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-08-21

Originally posted by: n.putt...@gmail.com

It's not ready yet: there are several comments I made which haven't been addressed.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-08-23

Originally posted by: jan.nieuwenhuizen

@neil: can you please specify/clarify?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Enhancement: MetronomeMark should support break-align-symbols

Issue Tracker for LilyPond

Searches

Help

#684 Enhancement: MetronomeMark should support break-align-symbols

Related

Discussion